Date: Wed, 19 Jul 2017 09:51:48 +0800
From: Peter Chen <hzpeterchen@gmail.com>
To: <frowand.list@gmail.com>
CC: Peter Chen <Peter.Chen@nxp.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <stable@vger.kernel.org>
Subject: Re: [PATCH] usb: chipidea: msm: ci_hdrc_msm_probe() missing
 of_node_get()
Message-ID: <20170719015147.GA26218@b29397-desktop>
References: <1500420688-11912-1-git-send-email-frowand.list@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1500420688-11912-1-git-send-email-frowand.list@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2017 01:52:22.8350
 (UTC)
X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0301MB0898
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1384
Lines: 41

On Tue, Jul 18, 2017 at 04:31:28PM -0700, frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@sony.com>
> 
> Boot fails for qcom-apq8074-dragonboard on 4.13-rc1 with error:
> OF: ERROR: Bad of_node_put() on /soc/usb@f9a55000
> 
> The error will occur if the configuration is set to:
>    CONFIG_OF_OVERLAY y
>    CONFIG_OF_UNITTEST y
>    CONFIG_OF_DYNAMIC y
>    CONFIG_OF_RESOLVE y
> 
> If CONFIG_OF_DYNAMIC is enabled then of_node_release() detects an
> attempt to release a node that is still attached to the device tree.
> 
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---
>  drivers/usb/chipidea/ci_hdrc_msm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c
> index 0bdfcdcbf7a5..bb626120296f 100644
> --- a/drivers/usb/chipidea/ci_hdrc_msm.c
> +++ b/drivers/usb/chipidea/ci_hdrc_msm.c
> @@ -251,7 +251,7 @@ static int ci_hdrc_msm_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto err_mux;
>  
> -	ulpi_node = of_find_node_by_name(pdev->dev.of_node, "ulpi");
> +	ulpi_node = of_find_node_by_name(of_node_get(pdev->dev.of_node), "ulpi");
>  	if (ulpi_node) {
>  		phy_node = of_get_next_available_child(ulpi_node, NULL);
>  		ci->hsic = of_device_is_compatible(phy_node, "qcom,usb-hsic-phy");
> -- 

Applied, thanks.

-- 

Best Regards,
Peter Chen