Date: Wed, 19 Jul 2017 10:56:00 +0800
From: Peter Chen <hzpeterchen@gmail.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
CC: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Peter Chen <peter.chen@nxp.com>, Mark Rutland <mark.rutland@arm.com>,
        Ulf Hansson <ulf.hansson@linaro.org>, Heiko Stuebner <heiko@sntech.de>,
        Stephen Boyd <stephen.boyd@linaro.org>, <frank.li@nxp.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Gary Bisson <gary.bisson@boundarydevices.com>,
        Fabio Estevam <festevam@gmail.com>,
        Joshua Clayton <stillcompiling@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
        Vaibhav Hiremath <vaibhav.hiremath@linaro.org>,
        Krzysztof Kozlowski <krzk@kernel.org>, <mka@chromium.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        <mail@maciej.szmigiero.name>, Pawel Moll <pawel.moll@arm.com>,
        Linux PM <linux-pm@vger.kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        <troy.kisky@boundarydevices.com>, Rob Herring <robh+dt@kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        <hverkuil@xs4all.nl>, <oscar@naiandei.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "open list:ULTRA-WIDEBAND (UWB) SUBSYSTEM:" 
        <linux-usb@vger.kernel.org>,
        Sebastian Reichel <sre@kernel.org>, Mark Brown <broonie@kernel.org>,
        <p.zabel@pengutronix.de>, Shawn Guo <shawnguo@kernel.org>,
        <jun.li@nxp.com>
Subject: Re: [PATCH v16 2/7] power: add power sequence library
Message-ID: <20170719025559.GC26218@b29397-desktop>
References: <1498027328-25078-1-git-send-email-peter.chen@nxp.com>
 <10723509.cz5GGA4OTz@aspire.rjw.lan>
 <20170710022815.GA8720@b29397-desktop>
 <2659617.dvNVihq86F@aspire.rjw.lan>
 <20170718042955.GA12080@b29397-desktop>
 <CAJZ5v0hGbJuqqY6Pq5cYPrawSGW-zdhYHj0ovhJ9zXRAkBPCRQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CAJZ5v0hGbJuqqY6Pq5cYPrawSGW-zdhYHj0ovhJ9zXRAkBPCRQ@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2017 02:56:42.4984
 (UTC)
X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB2122
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3582
Lines: 74

On Tue, Jul 18, 2017 at 07:06:05PM +0200, Rafael J. Wysocki wrote:
> On Tue, Jul 18, 2017 at 6:29 AM, Peter Chen <hzpeterchen@gmail.com> wrote:
> > On Mon, Jul 17, 2017 at 03:39:07PM +0200, Rafael J. Wysocki wrote:
> >> > Sorry, I should describe more.
> >> >
> >> > Let's take USB bus as an example, when the new USB device is at the
> >> > host port, the device structure at device model is not created until
> >> > it is discoverable by the USB bus. If this new USB device needs to be
> >> > powered on before can be discoverable by the bus, the device structure
> >> > will be not created without powering on operation. The code usb_alloc_dev
> >> > (drivers/usb/core/usb.c) is only called for discoverable device.
> >> >
> >> > Unlike the other bus, eg, platform bus, it creates device structure
> >> > according to DT node. The USB bus was designed for hot plug model, the
> >> > device structure is for discoverable device. In recent years, we begin
> >> > to have some hard-wired USB device, Eg, onboard USB-hub, onboard USB 4G
> >> > Modem, etc at the market. It needs some board level power operation before
> >> > it can be found by the USB bus. This patch set is designed primarily for
> >> > fix this kind of problem. You will see at at pwrseq_generic.c, we use DT
> >> > version clock API of_clk_get and DT version gpio API of_get_named_gpio_flags
> >> > instead of device structure version, like devm_clk_get and
> >> > devm_gpiod_get_optional.
> >> >
> >> > MMC system has similar use case, it creates power sequence platform
> >> > device for this issue, but all those power stuffs (clock, gpio, etc)
> >> > may not be suitable as a dedicated virtual device at DT, they are belonged
> >> > to one physical device, so this patch set is created to see if this issue
> >> > can be fixed better.
> >>
> >> OK, thanks for the explanation.
> >>
> >> The above needs to be part of your problem statement.
> >
> > Ok, I will add it to cover letter.
> >
> >> >
> >> > The bus will power up all device nodes in this bus according to DT
> >> > information, the device structure has not created at this time.
> >>
> >> OK
> >>
> >> I still think that the information on power resources depended on by devices
> >> should be used for power management as well as for the initial power-up.
> >>
> >> The most straightforward way to arrange for that would be to make it possible
> >> to find the DT node matching the device after the device has been discovered
> >> and struct device created for it, say by USB.  That would require adding some
> >> more information on the device to the DT node, probably.
> >
> > After the device is created, the device node structure is under struct
> > device, say dev->of_node. The most difficulty for this issue is the
> > device creation is dynamic and is after the physical device is
> > discovered by the bus, the initial power-up is needed before the device
> > can be discovered by the bus.
> 
> So you power up all devices on the bus using the information from
> of_nodes upfront.
> 

I think your mean call pm_device_power_up(struct device *dev) for bus
level device (eg, USB HUB for USB), yeah, I can do that. But we still
have below problem:

Where we can put the kinds of power sequence implementation
(eg, pwrseq_generic.c) and the match mechanism between device
node and kinds of power sequence(eg, of_pwrseq_on at core.c)? These
stuffs can be shared among subsystems, and is better to use
one framework for it. MMC subsystem adds such things at its core
folder (drivers/mmc/core/pwrseq*) currently.

-- 

Best Regards,
Peter Chen