Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752830AbdGSDAt (ORCPT ); Tue, 18 Jul 2017 23:00:49 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:34248 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752697AbdGSDAr (ORCPT ); Tue, 18 Jul 2017 23:00:47 -0400 From: Joseph Wright To: gregkh@linuxfoundation.org, linux@Wolf-Entwicklungen.de Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Joseph Wright Subject: [PATCH 2/2] Staging: pi433: check error after kthread_run() Date: Sun, 16 Jul 2017 14:48:58 +0000 Message-Id: <20170716144858.643-3-rjosephwright@gmail.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170716144858.643-1-rjosephwright@gmail.com> References: <20170716144858.643-1-rjosephwright@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 948 Lines: 29 Error should be checked with IS_ERR after calling kthread_run() instead of comparing the returned pointer to an int. Found by sparse warning: incompatible types for operation (<) left side has type struct task_struct *tx_task_struct right side has type int Signed-off-by: Joseph Wright --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 46461b4..4f724a5 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -1152,7 +1152,7 @@ static int pi433_probe(struct spi_device *spi) device->tx_task_struct = kthread_run(pi433_tx_thread, device, "pi433_tx_task"); - if (device->tx_task_struct < 0) + if (IS_ERR(device->tx_task_struct)) { dev_dbg(device->dev, "start of send thread failed"); goto send_thread_failed; -- 2.9.3