From: Michael Ellerman <mpe@ellerman.id.au>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>,
        kjlx@templeofstupid.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf probe: Fix build failure for get_target_map()
In-Reply-To: <20170718154538.GF10517@kernel.org>
References: <1499305693-1599-4-git-send-email-kjlx@templeofstupid.com> <1500287542-6219-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <20170717131108.GC10517@kernel.org> <874luaje4u.fsf@concordia.ellerman.id.au> <20170718154538.GF10517@kernel.org>
User-Agent: Notmuch/0.21 (https://notmuchmail.org)
Date: Wed, 19 Jul 2017 15:58:01 +1000
Message-ID: <87fudthst2.fsf@concordia.ellerman.id.au>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1144
Lines: 32

Arnaldo Carvalho de Melo <acme@kernel.org> writes:

> Em Tue, Jul 18, 2017 at 07:19:45PM +1000, Michael Ellerman escreveu:
>> Arnaldo Carvalho de Melo <acme@kernel.org> writes:
>> 
>> > Em Mon, Jul 17, 2017 at 04:02:22PM +0530, Ravi Bangoria escreveu:
>> >> Commit 801bc8193463 ("perf probe: Allow placing uprobes in
>> >> alternate namespaces.") is causing a build failure on powerpc:
>> >> 
>> >>   error: incompatible type for argument 2 of 'get_target_map'
>> >>   map = get_target_map(pev->target, pev->uprobes);
>> >>                                     ^~~
>> >> 
>> >> Fix it by changing parameters of get_target_map().
>> >
>> > Thanks, since this hasn't made it to Ingo I'll fold this into the patch
>> > where the problem was introduced, adding credits to you, leaving a Link
>> > to this message, so that we don't lose bisection in this area on
>> > powerpc.
>> 
>> Thanks.
>> 
>> I just bisected to this commit too - should have checked the list first! :)
>
> :-)
>
> I just re-ammended this cset to cover the !HAVE_DWARF_SUPPORT build as
> well, just re-force-pushed acme/perf/core with this fix.

Thanks, all green here.

cheers