Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752969AbdGSGBI (ORCPT ); Wed, 19 Jul 2017 02:01:08 -0400 Received: from mail.skyhub.de ([5.9.137.197]:33774 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751832AbdGSGBG (ORCPT ); Wed, 19 Jul 2017 02:01:06 -0400 Date: Wed, 19 Jul 2017 08:01:00 +0200 From: Borislav Petkov To: "Luck, Tony" Cc: Toshi Kani , "rjw@rjwysocki.net" , "mchehab@kernel.org" , "tglx@linutronix.de" , "srinivas.pandruvada@linux.intel.com" , "lenb@kernel.org" , "linux-acpi@vger.kernel.org" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 3/3] ghes_edac: add platform check to enable ghes_edac Message-ID: <20170719060059.GG26030@nazgul.tnic> References: <20170717215912.26070-1-toshi.kani@hpe.com> <20170717215912.26070-4-toshi.kani@hpe.com> <20170718060007.GB8736@nazgul.tnic> <3908561D78D1C84285E8C5FCA982C28F6130C6B8@ORSMSX114.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F6130C6B8@ORSMSX114.amr.corp.intel.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 601 Lines: 16 On Tue, Jul 18, 2017 at 10:13:42PM +0000, Luck, Tony wrote: > Historically we've had complaints that sb_edac won't load that have been > tracked to BIOS hiding one of the (many) PCI devices that it needs. But > device hiding is orthogonal to providing GHES error records. A BIOS might > do that, but I don't know that anyone intentionally does so. Yeah, the hiding-devices path doesn't look like the optimal one. I think we should look at the firmware-first setting and load ghes if FF is being done by the firmware. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --