Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753114AbdGSGZG (ORCPT ); Wed, 19 Jul 2017 02:25:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37948 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753098AbdGSGZF (ORCPT ); Wed, 19 Jul 2017 02:25:05 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0B93E19D24B Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=kraxel@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0B93E19D24B Message-ID: <1500445500.29197.3.camel@redhat.com> Subject: Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation From: Gerd Hoffmann To: "Zhang, Tina" , Kirti Wankhede , "Tian, Kevin" , "linux-kernel@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , "alex.williamson@redhat.com" , "zhenyuw@linux.intel.com" , "chris@chris-wilson.co.uk" , "Lv, Zhiyuan" , "intel-gvt-dev@lists.freedesktop.org" , "Wang, Zhi A" Date: Wed, 19 Jul 2017 08:25:00 +0200 In-Reply-To: <237F54289DF84E4997F34151298ABEBC7C58235A@SHSMSX101.ccr.corp.intel.com> References: <1499293795-6265-1-git-send-email-tina.zhang@intel.com> <980a5c09-fa8a-255d-19ad-acf4bb29d271@nvidia.com> <1499753648.8257.3.camel@redhat.com> <20170711091236.run4zirxmr34kazb@phenom.ffwll.local> <237F54289DF84E4997F34151298ABEBC7C57BF86@SHSMSX101.ccr.corp.intel.com> <20170712074038.izr6ureby4vwtq27@phenom.ffwll.local> <237F54289DF84E4997F34151298ABEBC7C57E3FF@SHSMSX101.ccr.corp.intel.com> <2c07d8ee-d974-33ec-2cf4-b320fc466c88@nvidia.com> <1500033939.28252.16.camel@redhat.com> <100da721-b765-ed65-7b4b-86e737e2889d@nvidia.com> <1500289405.12570.5.camel@redhat.com> <237F54289DF84E4997F34151298ABEBC7C58235A@SHSMSX101.ccr.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 19 Jul 2017 06:25:05 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1466 Lines: 41 On Wed, 2017-07-19 at 00:16 +0000, Zhang, Tina wrote: > > -----Original Message----- > > From: Gerd Hoffmann [mailto:kraxel@redhat.com] > > Sent: Monday, July 17, 2017 7:03 PM > > To: Kirti Wankhede ; Zhang, Tina > > ; Tian, Kevin ; linux- > > kernel@vger.kernel.org; intel-gfx@lists.freedesktop.org; > > alex.williamson@redhat.com; zhenyuw@linux.intel.com; chris@chris- > > wilson.co.uk; Lv, Zhiyuan ; intel-gvt- > > dev@lists.freedesktop.org; Wang, Zhi A > > Subject: Re: [PATCH v10] vfio: ABI for mdev display dma-buf > > operation > > > >   Hi, > > > > > No need of flag here. If vGPU driver is not loaded in the guest, > > > there > > > is no surface being managed by vGPU, in that case this size will > > > be > > > zero. > > > > Ok, we certainly have the same situation with intel.  When the > > guest driver is not > > loaded (yet) there is no valid surface. > > > > We should cleanly define what the ioctl should do in that case, so > > all drivers > > behave the same way. > > > > I'd suggest that all fields defining the surface (drm_format, > > width, height, stride, > > size) should be set to zero in that case. > > Yeah, it's reasonable. How about the return value? Currently, the > ioctl also returns "-ENODEV" in that situation. I think it should not return an error. Querying the plane parameters worked fine. cheers, Gerd