Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753121AbdGSGdP (ORCPT ); Wed, 19 Jul 2017 02:33:15 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34521 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752760AbdGSGdO (ORCPT ); Wed, 19 Jul 2017 02:33:14 -0400 Date: Wed, 19 Jul 2017 08:33:10 +0200 From: Daniel Vetter To: Manasi Navare Cc: Paul Kocialkowski , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter Subject: Re: [PATCH v2] drm/i915: Explicit the connector name for DP link training result Message-ID: <20170719063310.bqygy3fqtp6ypni4@phenom.ffwll.local> Mail-Followup-To: Manasi Navare , Paul Kocialkowski , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter References: <20170718142536.2306-1-paul.kocialkowski@linux.intel.com> <20170718192036.GB6173@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170718192036.GB6173@intel.com> X-Operating-System: Linux phenom 4.11.0-1-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2405 Lines: 60 On Tue, Jul 18, 2017 at 12:20:36PM -0700, Manasi Navare wrote: > On Tue, Jul 18, 2017 at 05:25:36PM +0300, Paul Kocialkowski wrote: > > This adds the connector name when printing a debug message about the DP > > link training result. It is useful to figure out what connector is > > failing when multiple DP connectors are used. > > > > Thanks for the patch, this does make sense during the link training > failure debugging to know the connector name. > While at it feel free to change "Failed", "Link Rate, Lane Count", to upper case > in the failure_handling case to be consistent with the pass case. > > Reviewed-by: Manasi Navare Applied, thanks. -Daniel > > Manasi > > > Signed-off-by: Paul Kocialkowski > > --- > > drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c > > index b79c1c0e404c..05907fa8a553 100644 > > --- a/drivers/gpu/drm/i915/intel_dp_link_training.c > > +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c > > @@ -321,12 +321,16 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) > > if (!intel_dp_link_training_channel_equalization(intel_dp)) > > goto failure_handling; > > > > - DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane count = %d", > > + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training Passed at Link Rate = %d, Lane count = %d", > > + intel_connector->base.base.id, > > + intel_connector->base.name, > > intel_dp->link_rate, intel_dp->lane_count); > > return; > > > > failure_handling: > > - DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane count = %d", > > + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training failed at link rate = %d, lane count = %d", > > + intel_connector->base.base.id, > > + intel_connector->base.name, > > intel_dp->link_rate, intel_dp->lane_count); > > if (!intel_dp_get_link_train_fallback_values(intel_dp, > > intel_dp->link_rate, > > -- > > 2.13.2 > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch