Date: Wed, 19 Jul 2017 09:20:02 +0200
From: Christoph Hellwig <hch@lst.de>
To: Vladimir Murzin <vladimir.murzin@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux@armlinux.org.uk, sza@esh.hu, arnd@arndb.de,
        gregkh@linuxfoundation.org, akpm@linux-foundation.org,
        alexandre.torgue@st.com, robin.murphy@arm.com, kbuild-all@01.org,
        benjamin.gaignard@linaro.org, hch@lst.de, m.szyprowski@samsung.com,
        vitaly_kuzmichev@mentor.com, george_davis@mentor.com
Subject: Re: [RFC PATCH 1/2] drivers: dma-coherent: Introduce interface for
        default DMA pool
Message-ID: <20170719072001.GA20840@lst.de>
References: <1500281885-3034-1-git-send-email-vladimir.murzin@arm.com> <1500281885-3034-2-git-send-email-vladimir.murzin@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1500281885-3034-2-git-send-email-vladimir.murzin@arm.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 753
Lines: 17

On Mon, Jul 17, 2017 at 09:58:04AM +0100, Vladimir Murzin wrote:
> Christoph noticed [1] that default DMA pool in current form overload
> the DMA coherent infrastructure. In reply, Robin suggested to split
> the per-device vs. global pool interfaces, so allocation/release from
> default DMA pool is driven by dma ops implementation.
> 
> This patch implements Robin's idea and provide interface to
> allocate/release/mmap the default/global DMA pool.
> 
> [1] https://lkml.org/lkml/2017/7/7/370
> [2] https://lkml.org/lkml/2017/7/7/431
> 
> Suggested-by: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>

This looks good to me.  I'd just rename the existin *_from_coherent
routines to *_from_dev_coherent.