Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752965AbdGSHts (ORCPT ); Wed, 19 Jul 2017 03:49:48 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:38329 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751581AbdGSHtr (ORCPT ); Wed, 19 Jul 2017 03:49:47 -0400 Subject: Re: [PATCH v2 1/1] xen/blkfront: always allocate grants first from per-queue persistent grants To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , konrad.wilk@oracle.com References: <1498654648-9970-1-git-send-email-dongli.zhang@oracle.com> <20170628153410.replhtna2tpaxbrw@dhcp-3-128.uk.xensource.com> Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com From: Dongli Zhang Message-ID: <146ea895-9576-5899-28b7-52b145ffe82c@oracle.com> Date: Wed, 19 Jul 2017 15:49:55 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20170628153410.replhtna2tpaxbrw@dhcp-3-128.uk.xensource.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 882 Lines: 26 Hi Konrad, In addition to Junxiao's patch on xen-blkfront, would you please help merge this to mainline as well? Thank you very much! Dongli Zhang On 06/28/2017 11:34 PM, Roger Pau Monn? wrote: > On Wed, Jun 28, 2017 at 08:57:28PM +0800, Dongli Zhang wrote: >> This patch partially reverts 3df0e50 ("xen/blkfront: pseudo support for >> multi hardware queues/rings"). The xen-blkfront queue/ring might hang due >> to grants allocation failure in the situation when gnttab_free_head is >> almost empty while many persistent grants are reserved for this queue/ring. >> >> As persistent grants management was per-queue since 73716df ("xen/blkfront: >> make persistent grants pool per-queue"), we should always allocate from >> persistent grants first. >> >> Signed-off-by: Dongli Zhang > > Acked-by: Roger Pau Monn? > > Thanks. >