Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753212AbdGSIJz (ORCPT ); Wed, 19 Jul 2017 04:09:55 -0400 Received: from mail-sn1nam02on0056.outbound.protection.outlook.com ([104.47.36.56]:3440 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753050AbdGSIJw (ORCPT ); Wed, 19 Jul 2017 04:09:52 -0400 From: "Kalderon, Michal" To: "Marciniszyn, Mike" , "Ismail, Mustafa" , "linux-rdma@vger.kernel.org" , "dledford@redhat.com" CC: "swise@opengridcomputing.com" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "e1000-rdma@lists.sourceforge.net" , "Saleem, Shiraz" , "Amrani, Ram" Subject: RE: [PATCH v2 2/2] RDMA/core: Initialize port_num in qp_attr Thread-Topic: [PATCH v2 2/2] RDMA/core: Initialize port_num in qp_attr Thread-Index: AQHS/K9nW4n2re2dvkWamddB2kN8+qJYZ3YAgAJqddA= Date: Wed, 19 Jul 2017 08:09:48 +0000 Message-ID: References: <1500043291-19768-1-git-send-email-mustafa.ismail@intel.com> <1500043291-19768-3-git-send-email-mustafa.ismail@intel.com> <32E1700B9017364D9B60AED9960492BC34341CD3@fmsmsx120.amr.corp.intel.com> In-Reply-To: <32E1700B9017364D9B60AED9960492BC34341CD3@fmsmsx120.amr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=cavium.com; x-originating-ip: [31.168.140.228] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CO2PR07MB2581;7:pg0BlQhD1R/0fFyBBS2uUAZNe5rJrkA7GLH/7JmPVK+nd6ZJVBI9LlNPclM9rf76zdE6GOQQJuhi2tmBU9N4/rOHb1rRVLh2Nwu2saHnUxTb9lrpuCWcN2qs5NikRuqYD+KG74YE0fn5z9gJtVuhA15gGax+dhRG2/+J28dmKXPn4LijOwQTPHUJJ6smUjusWne6aA8V5Vrh2c2BMP0PM87S/Cd7g/pStDcm3kti87vW454GFFCr2aZbKwQnPMiqBvzSejUD+kFSbstgGmC9F8mDh8M5Hd25W+11HQxjoTMMiiraG9Vr7gWqYmfXQB0vFP/yGuVb37X3HZ9Wi7xdHhilOxXev+hiMCMUr0Xj+pcttQcVRIl83nR7AoZkexYdjFTsWOW2sRapWGsLY4mSvxq/nIWO2dbocgWML1imigjxalCB9sPJPNjC5nW74DShKXsaqKGxJN8vKE/YCKk0diUEpBh0Tzl5VbFDBQzyy735GLPjr7wHQkyXT3eRA3SE8WrYG7sbv3mww1bK7VZz/aJlytV1I4BzjJiWEiy0FEAfpi7xf2CILtGhapvtqjiB0UKX/19l/yIyPvlOjNMg+yMLldcKOiLsiQcp+VP7CdAU4+AUnfNZrx0lyrXxJWxEnRe5uG2W1BPpvWVoGC4xs4ybP7W0k0BnPAIe+ATnk6hSULcDrJJ2+HipZyaPXFjppHDR4iDvXHQ0XZ/7A9lDE+wZWbWOK5fhmax0IeRg88OyyT7nNELyT3BoK6lARV4VPFsQX25trXZTSi6zl00Z4CHmtDqVYYP0A+2mUPb4byo= x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(6009001)(39450400003)(39840400002)(39410400002)(39400400002)(39850400002)(7736002)(229853002)(305945005)(2906002)(2950100002)(189998001)(5250100002)(3280700002)(3660700001)(54906002)(99286003)(55016002)(9686003)(2201001)(4326008)(102836003)(2501003)(6116002)(3846002)(86362001)(8676002)(478600001)(6506006)(81166006)(25786009)(8936002)(33656002)(107886003)(6246003)(54356999)(50986999)(76176999)(38730400002)(53936002)(6436002)(72206003)(74316002)(14454004)(5660300001)(66066001)(7696004)(2900100001);DIR:OUT;SFP:1101;SCL:1;SRVR:CO2PR07MB2581;H:DM2PR0701MB1392.namprd07.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; x-ms-office365-filtering-correlation-id: ebbeb281-8927-45a0-ee6b-08d4ce7d867f x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CO2PR07MB2581; x-ms-traffictypediagnostic: CO2PR07MB2581: x-exchange-antispam-report-test: UriScan:(236129657087228)(9452136761055)(228905959029699)(247924648384137); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(2017060910075)(5005006)(8121501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6041248)(20161123560025)(20161123558100)(20161123564025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CO2PR07MB2581;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CO2PR07MB2581; x-forefront-prvs: 0373D94D15 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2017 08:09:48.7441 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2581 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v6J8A1hb009209 Content-Length: 642 Lines: 15 > From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma- > owner@vger.kernel.org] On Behalf Of Marciniszyn, Mike > > Initialize the port_num for iWARP in rdma_init_qp_attr. > > > > Fixes: 5ecce4c9b17b("Check port number supplied by user verbs cmds") > > Cc: # v2.6.14+ > > Reviewed-by: Steve Wise > > Signed-off-by: Mustafa Ismail > Why is the second patch required if you only validate the port_num if the IB_QP_PORT mask is on? Given the first patch [PATCH v2 1/2] RDMA/uverbs: Fix the check for port number, this one seems redundant. Thanks, Michal