Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753397AbdGSIzb convert rfc822-to-8bit (ORCPT ); Wed, 19 Jul 2017 04:55:31 -0400 Received: from us-smtp-delivery-107.mimecast.com ([216.205.24.107]:52922 "EHLO us-smtp-delivery-107.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753336AbdGSIzY (ORCPT ); Wed, 19 Jul 2017 04:55:24 -0400 Subject: Re: [PATCH] clocksource: Convert to using %pOF instead of full_name To: Rob Herring , Daniel Lezcano , Thomas Gleixner CC: Maxime Coquelin , Alexandre Torgue , Linux ARM , LKML , DT References: <20170718214339.7774-13-robh@kernel.org> From: Marc Gonzalez Message-ID: Date: Wed, 19 Jul 2017 10:55:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.1 MIME-Version: 1.0 In-Reply-To: <20170718214339.7774-13-robh@kernel.org> X-Originating-IP: [172.27.0.114] X-MC-Unique: NY-c0UhMOpOFmTODW8QQTw-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2221 Lines: 62 On 18/07/2017 23:42, Rob Herring wrote: > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing > of the full path string for each node. Nice. For my own reference: http://elixir.free-electrons.com/linux/v4.13-rc1/source/Documentation/printk-formats.txt#L349 About removing the full path. Does this mean that ultimately %pOF will print just the name? And the 'f' spec will disappear? Is this done to save memory? > Signed-off-by: Rob Herring > Cc: Daniel Lezcano > Cc: Thomas Gleixner > Cc: Marc Gonzalez > Cc: Maxime Coquelin > Cc: Alexandre Torgue > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/clocksource/tango_xtal.c | 6 +++--- > drivers/clocksource/timer-of.c | 11 +++++------ > drivers/clocksource/timer-probe.c | 3 +-- > drivers/clocksource/timer-stm32.c | 8 ++++---- > 4 files changed, 13 insertions(+), 15 deletions(-) > > diff --git a/drivers/clocksource/tango_xtal.c b/drivers/clocksource/tango_xtal.c > index c4e1c2e6046f..6a8d9838ce33 100644 > --- a/drivers/clocksource/tango_xtal.c > +++ b/drivers/clocksource/tango_xtal.c > @@ -26,13 +26,13 @@ static int __init tango_clocksource_init(struct device_node *np) > > xtal_in_cnt = of_iomap(np, 0); > if (xtal_in_cnt == NULL) { > - pr_err("%s: invalid address\n", np->full_name); > + pr_err("%pOF: invalid address\n", np); > return -ENXIO; > } > > clk = of_clk_get(np, 0); > if (IS_ERR(clk)) { > - pr_err("%s: invalid clock\n", np->full_name); > + pr_err("%pOF: invalid clock\n", np); > return PTR_ERR(clk); > } > > @@ -43,7 +43,7 @@ static int __init tango_clocksource_init(struct device_node *np) > ret = clocksource_mmio_init(xtal_in_cnt, "tango-xtal", xtal_freq, 350, > 32, clocksource_mmio_readl_up); > if (ret) { > - pr_err("%s: registration failed\n", np->full_name); > + pr_err("%pOF: registration failed\n", np); > return ret; > } For drivers/clocksource/tango_xtal.c Acked-by: Marc Gonzalez Regards.