Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753405AbdGSJM5 (ORCPT ); Wed, 19 Jul 2017 05:12:57 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:40068 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752269AbdGSJMz (ORCPT ); Wed, 19 Jul 2017 05:12:55 -0400 Date: Wed, 19 Jul 2017 11:12:51 +0200 From: Sebastian Reichel To: Pavel Machek Cc: Rask Ingemann Lambertsen , Russell King , Richard Genoud , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, nico@linaro.org, gregory.clement@free-electrons.com, Linus Torvalds Subject: Re: [v4.13 regression] ARM: zImage: Fix stack overflow in merge_fdt_bootargs() Message-ID: <20170719091251.3jajjzf5qoc6le3h@earth> References: <257f11e3b0010a3a44c28b34a048278f7b960f3b.1500238579.git.rask@formelder.dk> <20170719081536.GA17727@amd> <20170719084727.lhjkr4kccc2xjw7r@earth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="njsy7qq6ml5anoh7" Content-Disposition: inline In-Reply-To: <20170719084727.lhjkr4kccc2xjw7r@earth> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2651 Lines: 70 --njsy7qq6ml5anoh7 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Wed, Jul 19, 2017 at 10:47:27AM +0200, Sebastian Reichel wrote: > On Wed, Jul 19, 2017 at 10:15:36AM +0200, Pavel Machek wrote: > > > This function is called very early on from head.S and currently sets = up a > > > stack frame of more than 1024 bytes: > > >=20 > > > atags_to_fdt.c: In function =E2=80=98merge_fdt_bootargs=E2=80=99: > > > atags_to_fdt.c:98:1: warning: the frame size of 1032 bytes is larger = than 1024 bytes [-Wframe-larger-than=3D] > > >=20 > > > This causes a crash and failure to boot with some combinations of ker= nel > > > version, gcc version and dtb, such as kernel version 4.1-rc1 of 4.1.0, > > > gcc version 5.4.1 20161019 (Debian 5.4.1-3) and tegra20-trimslice.dtb. > >=20 > > >=20 > > > Signed-off-by: Rask Ingemann Lambertsen > > > Fixes: d0f34a11ddab ("ARM: 7437/1: zImage: Allow DTB command line con= catenation with ATAG_CMDLINE") > >=20 > > I tested that it does not break boot on N900. I hoped that it would > > fix boot on N950 (but no luck there so far). > >=20 > > Tested-by: Pavel Machek > >=20 > > AFAICT this is regression in v4.13-rc1. Thus it is quite surprising > > that there are no comments here. >=20 > No, it's not. I definitely saw the warning before (and see it now) > and images can be booted on all of the phones I'm working on (i.e. > N900, N950, Droid 4). >=20 > Anyawys thanks for fixing this properly. I will add the patch to my > dev branch and give it a test during the day. It does work for me. Tested-by: Sebastian Reichel -- Sebastian --njsy7qq6ml5anoh7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAllvIpAACgkQ2O7X88g7 +pos8w//fjSFzDCXwDcR1iPvI4t2CZNIM8OlhFWIXBbn2fjLuuAjEqS1bIOk/U3N 0T+ZTphwCquM6CBmAaI/dPa+hXK6AGe9LQOIXu1vjCS2Mut5a2MXfQrzh70M2ajT jNZL/DtF+fZdQSKzH6vh5kvXDTDYfQgCbNcsaFFnm1YyN5GPhgYvjS1/vSXNPyRk NTyB3bkh+4Yn6zRhuBf9Bz9zOSraJZsAeZDPbhR8SvrwewhIzveaHhGqZM3XrUk/ zlRxUabGJjNr9DEC4keIQJ84cNzwpPvM2XzzsAX950ut5XbB4oBi60qKp4QCTMjY wDlD54AYOnF8TL5Fl+AdD0VT07BnPQ2u9i1r304+9VD7OxbQvMjDqi0sEyyqQqSs nbyoita6HfRRqKuq9j3xnMPtSp1BkXEyR0ih3VXYD16/tqDNoIPF8DOWgFS3Gu2S 0G68LEh769QSMnQmYPSu7YDkk526OM5Ecfg0syiLMzKonNUwRHyiDUHYMnh1x/YU 0wNhzD6KTXps+p4c3dQ9fPkTnu+vrN1389X02Xwtdrea22uYaJSf1lxRcjB5TRdX B1zMVl9MRePBthIW24+jG7GE8c3emR6sqAglTXffwQxDM+WSAMud3aH+4UWa7vxB 5kBQn4gOrhOvivO2CVSJV3E6roLzvz764lxk33qxFQpIEQdO/o8= =XDSl -----END PGP SIGNATURE----- --njsy7qq6ml5anoh7--