Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754636AbdGSK21 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 19 Jul 2017 06:28:27 -0400
Received: from smtprelay0218.hostedemail.com ([216.40.44.218]:33744 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1754570AbdGSK16 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 19 Jul 2017 06:27:58 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3350:3622:3866:3867:3868:3872:4321:5007:10004:10400:10848:11026:11232:11657:11658:11914:12043:12109:12296:12438:12679:12740:12760:12895:13069:13311:13357:13439:14659:14721:21080:21433:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none
X-HE-Tag: girls98_aff9aef6990b
X-Filterd-Recvd-Size: 1746
Message-ID: <1500460074.25934.33.camel@perches.com>
Subject: Re: [PATCH V2 net-next 20/21] net-next/hinic: Add ethtool and stats
From: Joe Perches <joe@perches.com>
To: Aviad Krawczyk <aviad.krawczyk@huawei.com>, davem@davemloft.net
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bc.y@huawei.com,
        victor.gissin@huawei.com, zhaochen6@huawei.com, tony.qu@huawei.com
Date: Wed, 19 Jul 2017 03:27:54 -0700
In-Reply-To: <b66411dd204e8989f58e70bea8ae11d2cbe5cd1b.1500454998.git.aviad.krawczyk@huawei.com>
References: <cover.1500454998.git.aviad.krawczyk@huawei.com>
         <b66411dd204e8989f58e70bea8ae11d2cbe5cd1b.1500454998.git.aviad.krawczyk@huawei.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.22.6-1ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 723
Lines: 29

On Wed, 2017-07-19 at 17:19 +0800, Aviad Krawczyk wrote:
> Add ethtool operations and statistics operations.

series trivia:

> diff --git a/drivers/net/ethernet/huawei/hinic/hinic_main.c b/drivers/net/ethernet/huawei/hinic/hinic_main.c
[]
> @@ -67,6 +67,178 @@
[]
> +static int hinic_get_link_ksettings(struct net_device *netdev,
> +				    struct ethtool_link_ksettings
> +				    *link_ksettings)
> +{
[]
> +	err = hinic_port_get_cap(nic_dev, &port_cap);
> +	if (err) {
> +		dev_err(&netdev->dev, "Failed to get port capabilities\n");
> +		return err;
> +	}

it looks like a lot of these dev_<level> calls
should be converted to netdev_<level>

from:
		dev_err(&netdev->dev, ...);
to:
		netdev_err(netdev, ...);

etc...