Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263310AbTFTQcs (ORCPT ); Fri, 20 Jun 2003 12:32:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263315AbTFTQcr (ORCPT ); Fri, 20 Jun 2003 12:32:47 -0400 Received: from mion.elka.pw.edu.pl ([194.29.160.35]:12702 "EHLO mion.elka.pw.edu.pl") by vger.kernel.org with ESMTP id S263310AbTFTQcn (ORCPT ); Fri, 20 Jun 2003 12:32:43 -0400 Date: Fri, 20 Jun 2003 18:46:17 +0200 (MET DST) From: Bartlomiej Zolnierkiewicz To: Matthew Wilcox cc: Greg KH , Subject: Re: [PATCH] PCI direct access resources In-Reply-To: <20030620162929.GT24357@parcelfarce.linux.theplanet.co.uk> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 566 Lines: 24 On Fri, 20 Jun 2003, Matthew Wilcox wrote: > + if (!pci_probe & PCI_PROBE_CONF1) > + goto type2; (!pci_probe & PCI_PROBE_CONF1) will be always FALSE if pci_probe != 0, correct check is: if ((pci_probe & PCI_PROBE_CONF1) == 0) > + if (!pci_probe & PCI_PROBE_CONF2) > + goto out; Same comment here. -- Bartlomiej - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/