Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754036AbdGSLXf (ORCPT ); Wed, 19 Jul 2017 07:23:35 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:45253 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753460AbdGSLXc (ORCPT ); Wed, 19 Jul 2017 07:23:32 -0400 X-Auth-Info: 43lU4Dp10ZFW9vgmdUW+g683mo6wfJ/7SdMFyjFs3eg= Date: Wed, 19 Jul 2017 13:23:27 +0200 From: Anatolij Gustschin To: Johan Hovold Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH] USB: serial: ftdi_sio: only bind FT232H if UART mode is enabled Message-ID: <20170719132327.2ddb8fbe@crub> In-Reply-To: <20170719090311.GV29638@localhost> References: <1499963125-19412-1-git-send-email-agust@denx.de> <20170719090311.GV29638@localhost> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1423 Lines: 32 On Wed, 19 Jul 2017 11:03:11 +0200 Johan Hovold johan@kernel.org wrote: >On Thu, Jul 13, 2017 at 06:25:25PM +0200, Anatolij Gustschin wrote: >> On FT232H the interface mode can be configured in the EEPROM, >> and the async UART mode is configured by default. The chip is >> also in async UART mode if no EEPROM is connected. >> >> Check the EEPROM configuration and do not bind as serial device >> when different interface mode is programmed in the EEPROM. > >Thanks for the patch. As you may have inferred from my reply to your MFD >series, this won't be needed for a while still however. > >Also note that some people already use asynchronous FIFO mode using this >driver (also mentioned in the datasheets as an option) so only binding >in UART mode would be too restrictive. You probably mean asynchronous bitbang mode, not asynchronous FIFO mode? This bitbang mode can always be set by sending a chip command (mentioned as software configured in the datasheets) Could you please point to code in this driver used for non-UART modes? I don't see such code by a quick glance. There are some quirks for various JTAG adapters to skip binding as serial port (the ftdi_sio driver is not used in JTAG operation modes then). Or do people use usual serial interface to send data in bitbang modes? Async and sync FIFO (FT245) modes however can only be configured via EEPROM settings, at least for FT232H. Thanks, Anatolij