Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753115AbdGSMtz (ORCPT ); Wed, 19 Jul 2017 08:49:55 -0400 Received: from mail-ve1eur01on0051.outbound.protection.outlook.com ([104.47.1.51]:43952 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751370AbdGSMtw (ORCPT ); Wed, 19 Jul 2017 08:49:52 -0400 From: =?iso-8859-2?Q?Horia_Geant=E3?= To: Oleksij Rempel , "kernel@pengutronix.de" , Dan Douglass , Herbert Xu , "David S. Miller" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v1] crypto: caam - set hwrng quality level Thread-Topic: [PATCH v1] crypto: caam - set hwrng quality level Thread-Index: AQHTAGL5pmG33iaaT0uDieR7tYnZTg== Date: Wed, 19 Jul 2017 12:49:47 +0000 Message-ID: References: <20170719074458.9247-1-o.rempel@pengutronix.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: pengutronix.de; dkim=none (message not signed) header.d=none;pengutronix.de; dmarc=none action=none header.from=nxp.com; x-originating-ip: [192.88.146.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR0401MB2624;7:G3otPeAuYVdpXrDP8afdSeSnYMQ5ZH1OSmTi5Xrn5EVy+i/tbKFavmxCMMaaWv3w77BUqNPWGbfF/RUGf64yuonwgE1+4FsYawmgvLvWS9ovBKs+rquULZ0u/WadcAkOHImSCx7xyYH4416i+aPab1/qdngyHZxMf6NE89LQrSVSfzlBBC7E9LSCahTQKD8RCOzt2eiC6eWPRvJ7ZbC1xNXRBrmJVt2g2WmjUTrNqZEFv0qgzk9Ct7jmkUe69lZtnvM/SVXm2mAGWpirsVP4Ok4raY3ZVDcrlJDRmo4bsGVVwq0Krr9E608CFdH3xFgN7v/dNCyMgOSJslGKc0Pqo8g8+tNHxTsHDb4h6aLfP17vOtaiTOKSNSAynnaJRjNMo0b8pFzWUOarXbiqK/8AqNFeoc46BicTikaGwtIAZjv9DxJyDiwnnOhoGkbDvK89CYlBZ/QuNUBmQ/iZn4/FXP1zhpwPUgm26f6oaPpxR1l3DEELxZWh7hKwLA/qUu6gbh77Cz+8LZoHGl38XpGw2jXIC4HCYrjx9wqguJh/9jDBM1AD674vfaqUmvz1q3f6YgDk8/gZ5/+A1QHHPLAsOBloJaQ8HKCeQTPzXcOMc3G+6cxH4n7CMdp6VYCUd7bhVSsnL+ikVPByIHl59EBeXiOjAEoB9dHvkfKjlnpe2IS81ZK6FrJPmt1aAbFBafqmEzmU7ua5EDIiikoYwxF4hoWR8QyvqbatU6WBIY4ZjDLobcbdHe7mditg1A5oZ26r96ropIobFsW8UwDGCILTaEae767IIjkVN1bOrScsHlo= x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(6009001)(39400400002)(39410400002)(39850400002)(39840400002)(39450400003)(39860400002)(377454003)(24454002)(7736002)(99286003)(53936002)(55016002)(189998001)(6506006)(8676002)(81166006)(8936002)(50986999)(54356999)(575784001)(76176999)(53546010)(66066001)(2900100001)(86362001)(2906002)(2201001)(9686003)(5250100002)(305945005)(7696004)(6116002)(3846002)(33656002)(38730400002)(3660700001)(14454004)(6246003)(25786009)(6436002)(3280700002)(5660300001)(229853002)(74316002)(102836003)(2501003)(478600001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0401MB2624;H:VI1PR0401MB2591.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; x-ms-office365-filtering-correlation-id: 15af5b81-d87b-437f-4a10-08d4cea4a39c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(300000503095)(300135400095)(48565401081)(2017052603031)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:VI1PR0401MB2624; x-ms-traffictypediagnostic: VI1PR0401MB2624: x-exchange-antispam-report-test: UriScan:(236129657087228); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(2017060910075)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123558100)(20161123564025)(20161123560025)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:VI1PR0401MB2624;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:VI1PR0401MB2624; x-forefront-prvs: 0373D94D15 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-2" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2017 12:49:47.8347 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2624 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v6JCoEiX030624 Content-Length: 978 Lines: 32 On 7/19/2017 10:45 AM, Oleksij Rempel wrote: > According documentation, it is NIST certified TRNG. > So, set high quality to let the HWRNG framework automatically use it. > > Signed-off-by: Oleksij Rempel > --- > drivers/crypto/caam/caamrng.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/crypto/caam/caamrng.c b/drivers/crypto/caam/caamrng.c > index 41398da3edf4..684c0bc88dfd 100644 > --- a/drivers/crypto/caam/caamrng.c > +++ b/drivers/crypto/caam/caamrng.c > @@ -292,10 +292,16 @@ static int caam_init_rng(struct caam_rng_ctx *ctx, struct device *jrdev) > return 0; > } > > +/* > + * hwrng register struct > + * The trng is suppost to have 100% entropy, and thus > + * we register with a very high quality value. > + */ > static struct hwrng caam_rng = { > .name = "rng-caam", > .cleanup = caam_cleanup, > .read = caam_read, > + .quality = 999, Why not 1024, i.e. where is 999 coming from? Thanks, Horia