Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753622AbdGSMu5 (ORCPT ); Wed, 19 Jul 2017 08:50:57 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:3256 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753539AbdGSMuy (ORCPT ); Wed, 19 Jul 2017 08:50:54 -0400 From: Gabriel FERNANDEZ To: Vladimir Zapolskiy , Alexandre TORGUE , Michael Turquette , Stephen Boyd CC: Rob Herring , Mark Rutland , Russell King , Maxime Coquelin , Nicolas Pitre , Arnd Bergmann , "daniel.thompson@linaro.org" , "andrea.merello@gmail.com" , "radoslaw.pietrzyk@gmail.com" , Lee Jones , Sylvain Lemieux , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-clk@vger.kernel.org" , Ludovic BARRE , "Olivier BIDEAU" , Amelie DELAUNAY , "gabriel.fernandez.st@gmail.com" , "Arvind Yadav" Subject: Re: [PATCH v6 1/3] clk: nxp: clk-lpc32xx: rename clk_gate_is_enabled() Thread-Topic: [PATCH v6 1/3] clk: nxp: clk-lpc32xx: rename clk_gate_is_enabled() Thread-Index: AQHS/5r6kxfJtovHTkirgUc3Dy3bBaJZ3OGAgAEdboA= Date: Wed, 19 Jul 2017 12:50:01 +0000 Message-ID: <63be565e-4f3c-725c-c31b-a333b9bde89d@st.com> References: <1500364414-10021-1-git-send-email-gabriel.fernandez@st.com> <1500364414-10021-2-git-send-email-gabriel.fernandez@st.com> <20f6a994-26b4-578c-d641-395639ebac0f@mleia.com> In-Reply-To: <20f6a994-26b4-578c-d641-395639ebac0f@mleia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.50] Content-Type: text/plain; charset="utf-8" Content-ID: <9405753940680D409C51CF05C0AB097A@st.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-07-19_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v6JCp3Q7030636 Content-Length: 1939 Lines: 61 Hi Vladimir, Many thanks for the code review. On 07/18/2017 09:48 PM, Vladimir Zapolskiy wrote: > Hello Gabriel, > > On 07/18/2017 10:53 AM, gabriel.fernandez@st.com wrote: >> From: Gabriel Fernandez >> >> We need to export clk_gate_is_enabled() from clk framework, then > first of all let's clarify if you really need to export clk_gate_is_enabled() > from the CCF. Yes i really need to export clk_gate_is_enabled() >> to avoid compilation issue we have to rename clk_gate_is_enabled() >> in NXP LPC32xx clock driver. >> >> Signed-off-by: Gabriel Fernandez >> --- >> drivers/clk/nxp/clk-lpc32xx.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/clk/nxp/clk-lpc32xx.c b/drivers/clk/nxp/clk-lpc32xx.c >> index 5b98ff9..1cc71ad 100644 >> --- a/drivers/clk/nxp/clk-lpc32xx.c >> +++ b/drivers/clk/nxp/clk-lpc32xx.c >> @@ -903,7 +903,7 @@ static void clk_gate_disable(struct clk_hw *hw) >> regmap_update_bits(clk_regmap, clk->reg, mask, val); >> } >> >> -static int clk_gate_is_enabled(struct clk_hw *hw) >> +static int __clk_gate_is_enabled(struct clk_hw *hw) >> { >> struct lpc32xx_clk_gate *clk = to_lpc32xx_gate(hw); >> u32 val; >> @@ -918,7 +918,7 @@ static int clk_gate_is_enabled(struct clk_hw *hw) >> static const struct clk_ops lpc32xx_clk_gate_ops = { >> .enable = clk_gate_enable, >> .disable = clk_gate_disable, >> - .is_enabled = clk_gate_is_enabled, >> + .is_enabled = __clk_gate_is_enabled, > In case if this change gets continuation, here I want to see the same > prefixes for all functions and no underscores, namely it shall be > * lpc32xx_clk_gate_enable(), > * lpc32xx_clk_gate_disable(), > * lpc32xx_clk_gate_is_enabled(). ok il will use same prefixes for all functions Best regards Gabriel. >> }; >> >> #define div_mask(width) ((1 << (width)) - 1) >> > -- > With best wishes, > Vladimir