Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753901AbdGSNjb (ORCPT <rfc822;w@1wt.eu>);
        Wed, 19 Jul 2017 09:39:31 -0400
Received: from mail.kernel.org ([198.145.29.99]:43894 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753408AbdGSNj3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 19 Jul 2017 09:39:29 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5004622C91
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh+dt@kernel.org
MIME-Version: 1.0
In-Reply-To: <1500436340-7748-2-git-send-email-frowand.list@gmail.com>
References: <1500436340-7748-1-git-send-email-frowand.list@gmail.com> <1500436340-7748-2-git-send-email-frowand.list@gmail.com>
From: Rob Herring <robh+dt@kernel.org>
Date: Wed, 19 Jul 2017 08:39:07 -0500
X-Gmail-Original-Message-ID: <CAL_Jsq+2VDvgK-N93rOYAJ=TSGDJeJfP_ba0jM2=suLZ6OBrtQ@mail.gmail.com>
Message-ID: <CAL_Jsq+2VDvgK-N93rOYAJ=TSGDJeJfP_ba0jM2=suLZ6OBrtQ@mail.gmail.com>
Subject: Re: [PATCH v3 1/3] of: overlay: add overlay unittest data for node
 names and symbols
To: Frank Rowand <frowand.list@gmail.com>
Cc: Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
        Pantelis Antoniou <panto@antoniou-consulting.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1416
Lines: 44

On Tue, Jul 18, 2017 at 10:52 PM,  <frowand.list@gmail.com> wrote:
> From: Frank Rowand <frank.rowand@sony.com>
>
> Add nodes and properties to overlay_base and overlay dts files to
> test for
>    - incorrect existing node name detection when overlay node name
>      has a unit-address
>    - adding overlay __symbols__ properties to live tree when an
>      overlay is added to the live tree
>
> The following console messages will appear near the end of unittest
> until the code errors are corrected:
>
>    OF: Duplicate name in fairway-1, renamed to "ride@100#1"
>
>    ### dt-test ### FAIL of_unittest_overlay_high_level():2296 Adding overlay 'overlay_bad_symbol' failed
>
>    ### dt-test ### end of unittest - 190 passed, 1 failed
>
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---

> diff --git a/drivers/of/unittest-data/overlay.dts b/drivers/of/unittest-data/overlay.dts
> index 6cd7e6a0c13e..81140adbe770 100644
> --- a/drivers/of/unittest-data/overlay.dts
> +++ b/drivers/of/unittest-data/overlay.dts
> @@ -25,7 +25,18 @@
>                         #size-cells = <1>;
>                         status = "ok";
>
> -                       ride@200 {
> +                       ride@100 {
> +
> +                               track@3 {

These need a reg property.

> +                                       incline_up = < 48 32 16 >;

Don't use '_'.

Build with W=2 to check dtc warnings.

Rob