Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753496AbdGSOSN (ORCPT ); Wed, 19 Jul 2017 10:18:13 -0400 Received: from mail-oi0-f50.google.com ([209.85.218.50]:34848 "EHLO mail-oi0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752892AbdGSOSL (ORCPT ); Wed, 19 Jul 2017 10:18:11 -0400 MIME-Version: 1.0 In-Reply-To: <20170719141153.GA17303@potion> References: <20170719125310.2487451-1-arnd@arndb.de> <20170719125310.2487451-7-arnd@arndb.de> <20170719141153.GA17303@potion> From: Arnd Bergmann Date: Wed, 19 Jul 2017 16:18:09 +0200 X-Google-Sender-Auth: iAGPEPCsmcae4bvvNff6-ZH4_u0 Message-ID: Subject: Re: [PATCH 6/8] x86: add MULTIUSER dependency for KVM To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Cc: "the arch/x86 maintainers" , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Linux Kernel Mailing List , Alex Williamson , kvm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v6JEIIFm002041 Content-Length: 920 Lines: 23 On Wed, Jul 19, 2017 at 4:11 PM, Radim Krčmář wrote: > 2017-07-19 14:53+0200, Arnd Bergmann: >> KVM tries to select 'TASKSTATS', which had additional dependencies: >> >> warning: (KVM) selects TASKSTATS which has unmet direct dependencies (NET && MULTIUSER) >> >> Signed-off-by: Arnd Bergmann >> --- > > Hm, do you know why Kconfig warns instead of propagating the > dependencies? Kconfig propagates 'depends on' dependencies, but cannot turn a 'select' into 'depends on', as those two mean different things. Another solution to the problem would be to use 'depends on TASKSTATS'. Generally speaking, using 'select' to turn on a user-visible option is a bad idea, but blindly turning those 'select' into 'depends on' is also dangerous, as it can break configurations of existing users that would here end up with neither TASKSTATS nor KVM after a 'make oldconfig'. Arnd