Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753740AbdGSOUP (ORCPT ); Wed, 19 Jul 2017 10:20:15 -0400 Received: from mail-yw0-f173.google.com ([209.85.161.173]:34086 "EHLO mail-yw0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753603AbdGSOUM (ORCPT ); Wed, 19 Jul 2017 10:20:12 -0400 Date: Wed, 19 Jul 2017 14:20:11 +0000 From: Josef Bacik To: Matthew Wilcox Cc: Josef Bacik , Dennis Zhou , Tejun Heo , Christoph Lameter , kernel-team@fb.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Dennis Zhou Subject: Re: [PATCH 06/10] percpu: modify base_addr to be region specific Message-ID: <20170719142010.GB23135@li70-116.members.linode.com> References: <20170716022315.19892-1-dennisz@fb.com> <20170716022315.19892-7-dennisz@fb.com> <20170718192601.GB4009@destiny> <20170718193627.GA18303@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170718193627.GA18303@bombadil.infradead.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 657 Lines: 17 On Tue, Jul 18, 2017 at 12:36:27PM -0700, Matthew Wilcox wrote: > On Tue, Jul 18, 2017 at 03:26:02PM -0400, Josef Bacik wrote: > > On Sat, Jul 15, 2017 at 10:23:11PM -0400, Dennis Zhou wrote: > > > + map_size_bytes = (ai->reserved_size ?: ai->dyn_size) + > > > + pcpu_reserved_offset; > > > > This confused me for a second, better to be explicit with > > > > (ai->reserved_size ? 0 : ai->dyn_size) + pcpu_reserved_offset; > > You're still confused ;-) What Dennis wrote is equivalent to: > > (ai->reserved_size ? ai->reserved_size : ai->dyn_size) + pcpu_reserved_offset; Lol jesus, made my point even harder with me being an idiot. Thanks, Josef