Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754811AbdGSOjK convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Wed, 19 Jul 2017 10:39:10 -0400
Received: from mga07.intel.com ([134.134.136.100]:58904 "EHLO mga07.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933021AbdGSOiX (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 19 Jul 2017 10:38:23 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.40,381,1496127600"; 
   d="scan'208";a="1197246885"
From: "Ismail, Mustafa" <mustafa.ismail@intel.com>
To: "Kalderon, Michal" <Michal.Kalderon@cavium.com>,
        "Marciniszyn, Mike" <mike.marciniszyn@intel.com>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "dledford@redhat.com" <dledford@redhat.com>
CC: "swise@opengridcomputing.com" <swise@opengridcomputing.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        "e1000-rdma@lists.sourceforge.net" <e1000-rdma@lists.sourceforge.net>,
        "Saleem, Shiraz" <shiraz.saleem@intel.com>,
        "Amrani, Ram" <Ram.Amrani@cavium.com>
Subject: RE: [PATCH v2 2/2] RDMA/core: Initialize port_num in qp_attr
Thread-Topic: [PATCH v2 2/2] RDMA/core: Initialize port_num in qp_attr
Thread-Index: AQHS/K9rF4PQyALVdEq0fM3qwe5bIKJYZ0lQgALhdwD///ElQA==
Date: Wed, 19 Jul 2017 14:38:18 +0000
Message-ID: <5C5647B5F4794941BAAC07CF28785CBC33E5F3B1@fmsmsx101.amr.corp.intel.com>
References: <1500043291-19768-1-git-send-email-mustafa.ismail@intel.com>
 <1500043291-19768-3-git-send-email-mustafa.ismail@intel.com>
 <32E1700B9017364D9B60AED9960492BC34341CD3@fmsmsx120.amr.corp.intel.com>
 <DM2PR0701MB13920AC9BBE7471A921FBF0A88A60@DM2PR0701MB1392.namprd07.prod.outlook.com>
In-Reply-To: <DM2PR0701MB13920AC9BBE7471A921FBF0A88A60@DM2PR0701MB1392.namprd07.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDU5ZWFmN2EtZTY1OC00NmVkLWFkMDAtNzU3MmEzMGY3Zjg0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImpBeE1JTnNTVzNjNlIwenJ1bXgzeElJOU5qU0Z3S1VrcWhpV1wveldFTWF3PSJ9
x-ctpclassification: CTP_IC
dlp-product: dlpe-windows
dlp-version: 10.0.102.7
dlp-reaction: no-action
x-originating-ip: [10.1.200.106]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1352
Lines: 30

> -----Original Message-----
> From: Kalderon, Michal [mailto:Michal.Kalderon@cavium.com]
> Sent: Wednesday, July 19, 2017 3:10 AM
> To: Marciniszyn, Mike <mike.marciniszyn@intel.com>; Ismail, Mustafa
> <mustafa.ismail@intel.com>; linux-rdma@vger.kernel.org;
> dledford@redhat.com
> Cc: swise@opengridcomputing.com; linux-kernel@vger.kernel.org;
> stable@vger.kernel.org; e1000-rdma@lists.sourceforge.net; Saleem, Shiraz
> <shiraz.saleem@intel.com>; Amrani, Ram <Ram.Amrani@cavium.com>
> Subject: RE: [PATCH v2 2/2] RDMA/core: Initialize port_num in qp_attr
> 
> > From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma-
> > owner@vger.kernel.org] On Behalf Of Marciniszyn, Mike
> > > Initialize the port_num for iWARP in rdma_init_qp_attr.
> > >
> > > Fixes: 5ecce4c9b17b("Check port number supplied by user verbs cmds")
> > > Cc: <stable@vger.kernel.org> # v2.6.14+
> > > Reviewed-by: Steve Wise <swise@opengridcomputing.com>
> > > Signed-off-by: Mustafa Ismail <mustafa.ismail@intel.com>
> >
> Why is the second patch required if you only validate the port_num if the
> IB_QP_PORT mask is on?
> Given the first patch [PATCH v2 1/2] RDMA/uverbs: Fix the check for port
> number, this one seems redundant.
Strictly speaking it is not required, but we felt it safer to always return a valid port number
as is done in the IB case.

Regards,

Mustafa