Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754931AbdGSOpA (ORCPT ); Wed, 19 Jul 2017 10:45:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:51166 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932150AbdGSOfS (ORCPT ); Wed, 19 Jul 2017 10:35:18 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0FE523695 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Wed, 19 Jul 2017 11:35:14 -0300 From: Arnaldo Carvalho de Melo To: "Liang, Kan" Cc: Jiri Olsa , "linux-kernel@vger.kernel.org" , "mingo@redhat.com" , "peterz@infradead.org" , "Hunter, Adrian" , "alexander.shishkin@linux.intel.com" , "ak@linux.intel.com" Subject: Re: [PATCH V2 2/2] perf tools: always set no branch for dummy event in PT Message-ID: <20170719143514.GE20962@kernel.org> References: <20170630141656.1626-1-kan.liang@intel.com> <20170630141656.1626-2-kan.liang@intel.com> <20170703075832.GA10105@krava> <20170703165922.GD16278@kernel.org> <37D7C6CF3E00A74B8858931C1DB2F0775371EBA9@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F0775371EBA9@SHSMSX103.ccr.corp.intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1233 Lines: 40 Em Wed, Jul 19, 2017 at 02:28:26PM +0000, Liang, Kan escreveu: > > > > Em Mon, Jul 03, 2017 at 09:58:32AM +0200, Jiri Olsa escreveu: > > > On Fri, Jun 30, 2017 at 10:16:56AM -0400, kan.liang@intel.com wrote: > > > > From: Kan Liang > > > > > > > > An earlier kernel patch allowed enabling PT and LBR at the same time > > > > on Goldmont. > > > > > > > > commit ccbebba4c6bf ("perf/x86/intel/pt: Bypass PT vs. LBR > > > > exclusivity if the core supports it") > > > > > > > > However, users still cannot use Intel PT and LBRs simultaneously. > > > > $ sudo perf record -e cycles,intel_pt//u -b -- sleep 1 > > > > Error: > > > > PMU Hardware doesn't support sampling/overflow-interrupts. > > > > > > > > PT implicitly adds dummy event in perf tool. dummy event is software > > > > event which doesn't support LBR. > > > > > > > > Always setting no branch for dummy event in Intel PT. > > > > > > > > Signed-off-by: Kan Liang > > > > > > for the patchset: > > > > > > Acked-by: Jiri Olsa > > > > Thanks, applied. > > > > Hi Arnaldo, > > The patch series looks miss the latest update. > Could you please have a look? Will, check, thanks for verifying. - Arnaldo