Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754252AbdGSPTp (ORCPT ); Wed, 19 Jul 2017 11:19:45 -0400 Received: from mail-sn1nam01on0136.outbound.protection.outlook.com ([104.47.32.136]:58323 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753467AbdGSPTn (ORCPT ); Wed, 19 Jul 2017 11:19:43 -0400 From: Haiyang Zhang To: Mohammed Gamal , KY Srinivasan , Stephen Hemminger CC: "devel@linuxdriverproject.org" , "linux-kernel@vger.kernel.org" , "vkuznets@redhat.com" , "cavery@redhat.com" , "otubo@redhat.com" Subject: RE: [PATCH] netvsc: Remove redundant use of ipv6_hdr() Thread-Topic: [PATCH] netvsc: Remove redundant use of ipv6_hdr() Thread-Index: AQHTAJG4esKUSvpzWUaPgXtVINqo1KJbQ4aQ Date: Wed, 19 Jul 2017 15:19:40 +0000 Message-ID: References: <20170719131928.18209-1-mgamal@redhat.com> In-Reply-To: <20170719131928.18209-1-mgamal@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Ref=https://api.informationprotection.azure.com/api/72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=haiyangz@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2017-07-19T11:19:38.9150963-04:00; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General x-originating-ip: [69.128.199.77] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MWHPR21MB0159;7:T0/pKUM4w1qFrnENtHr3T6Qxj7YtFso+Dw7ypAjY2uq130EkotO1NgEmDg9/xbs4+5xU1getooaB52m53ZApmOJ0xbkF49D7pF0sR8JpJiyVVCv6lbwi8gkJUD9fzlHrG6agfwO6fJFWFejxObr2+T7ol94QmBVDoinC0dIwIiEYAmhyuejdx5FM40tAQpO+WVlsMSRFV86pt3pc/PMBpSxdf8LZtwTxS6stU6DNkE3RArFNObH4TDaTJZPFS+oOReOEZRlVKikCu0wdNE3OSkIPxYkk5qP7X8g1A6nky8tcfGQwChfPp5mK4hTr+vZ6LzN9dpSvwfvLHKyo/XQ3K0v48+jgVO3czutrvBhdO4ec2T1xhFqC3ZzCBaEalqgDd9RYNZIjB4a2V+uNIoeApGsLi4WMHfIwhcdp0uk4u88ds+j1MqKqxqb9XlKe6plCYxp1ZDLgnCz78ovseUPrGcA0LALs8FJ03FG1LC6UmijruOtR/wqOXDNSx2RqnHIAQ5aRwGuavfKD1/Jf8B2fruHoLrXGE/FRdPnMcb5RpF7KiS9ofD6gXtjFem5BbMZqUbOM5wGXDX/d9ve+AnVLzlh4huh+2CRJfXDWtAjmPIFdAiMs3qSJhF5REQ1+cM8X+i3epcmAUx6fujTGe+6V0XL735fNYhZdYkNjLiUtGm+pgiWoAQVd77W3bAhlb89OdBwVKHAPDnxN6DFH2c3b+BqVXBOh7qb6ylBV4WrRQlk2ztVt1M2EzuVeeLl6EF44gVKvdYSMpYbA9WrYC/LQRIdsRbMe6ulSNELHFhA3vewFEuSBACZnSnMG9EbrnOGI x-ms-office365-filtering-correlation-id: 00c58023-a96c-411f-b186-08d4ceb993b4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(48565401081)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:MWHPR21MB0159; x-ms-traffictypediagnostic: MWHPR21MB0159: authentication-results: outbound.protection.outlook.com: dkim=none (message not signed) header.d=none; dmarc=none action=none header.from=microsoft.com; x-exchange-antispam-report-test: UriScan:(236129657087228)(9452136761055); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(601004)(2401047)(8121501046)(5005006)(2017060910075)(10201501046)(93006095)(93001095)(3002001)(100000703101)(100105400095)(6055026)(61426038)(61427038)(6041248)(20161123555025)(20161123560025)(20161123558100)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR21MB0159;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR21MB0159; x-forefront-prvs: 0373D94D15 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39850400002)(39410400002)(39400400002)(39450400003)(39860400002)(39840400002)(377454003)(13464003)(7696004)(10290500003)(55016002)(5660300001)(2900100001)(99286003)(50986999)(189998001)(54906002)(54356999)(76176999)(3660700001)(8676002)(2906002)(81166006)(8936002)(6506006)(53546010)(6436002)(3280700002)(77096006)(25786009)(229853002)(6636002)(6246003)(2950100002)(38730400002)(305945005)(10090500001)(4326008)(5005710100001)(9686003)(53936002)(478600001)(3846002)(102836003)(6116002)(74316002)(86362001)(14454004)(7736002)(2561002)(33656002)(66066001)(1511001);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR21MB0159;H:MWHPR21MB0479.namprd21.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2017 15:19:40.7040 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0159 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v6JFJpYl006072 Content-Length: 722 Lines: 20 > -----Original Message----- > From: Mohammed Gamal [mailto:mgamal@redhat.com] > Sent: Wednesday, July 19, 2017 9:19 AM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > Cc: devel@linuxdriverproject.org; linux-kernel@vger.kernel.org; > vkuznets@redhat.com; cavery@redhat.com; otubo@redhat.com; Mohammed Gamal > > Subject: [PATCH] netvsc: Remove redundant use of ipv6_hdr() > > This condition already uses an object of type ipv6hdr in the line above. > Use the object directly instead of calling ipv6_hdr > > Signed-off-by: Mohammed Gamal Reviewed-by: Haiyang Zhang Thanks.