Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933484AbdGSPfp convert rfc822-to-8bit (ORCPT ); Wed, 19 Jul 2017 11:35:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:60250 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753853AbdGSPfm (ORCPT ); Wed, 19 Jul 2017 11:35:42 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B265322CAA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh@kernel.org MIME-Version: 1.0 In-Reply-To: <20170719062220.wefnkqhd7javbcee@pengutronix.de> References: <20170718214339.7774-1-robh@kernel.org> <20170719062220.wefnkqhd7javbcee@pengutronix.de> From: Rob Herring Date: Wed, 19 Jul 2017 10:35:20 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ARM: Convert to using %pOF instead of full_name To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: "arm@kernel.org" , Andrew Lunn , Heiko Stuebner , Tony Lindgren , "linux-samsung-soc@vger.kernel.org" , "open list:ARM/Rockchip SoC..." , Magnus Damm , Russell King , Krzysztof Kozlowski , Javier Martinez Canillas , Kukjin Kim , Sebastian Hesselbarth , "devicetree@vger.kernel.org" , Jason Cooper , Simon Horman , Gregory Clement , linux-omap , Sascha Hauer , "linux-arm-kernel@lists.infradead.org" , Paul Walmsley , "linux-kernel@vger.kernel.org" , "open list:MEDIA DRIVERS FOR RENESAS - FCP" , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Fabio Estevam , Shawn Guo Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1213 Lines: 32 On Wed, Jul 19, 2017 at 1:22 AM, Uwe Kleine-König wrote: > On Tue, Jul 18, 2017 at 04:42:41PM -0500, Rob Herring wrote: >> Now that we have a custom printf format specifier, convert users of >> full_name to use %pOF instead. This is preparation to remove storing > > Oh nice. If the commit adding %pOF is already set in stone, i'd suggest > to mention the commit id here in the commit log. It is in 4.13, but I'm not really eager to update all 60 patches and I'd prefer consistency in the commit msg as quite a few have already been applied. >> of the full path string for each node. [...] >> @@ -103,8 +103,8 @@ void __init arm_dt_init_cpu_maps(void) >> */ >> cell = of_get_property(cpu, "reg", &prop_bytes); >> if (!cell || prop_bytes < sizeof(*cell)) { >> - pr_debug(" * %s missing reg property\n", >> - cpu->full_name); >> + pr_debug(" * %pOF missing reg property\n", >> + cpu); > > You could join lines here and in the next hunk. And there are two more > further down. Okay. I did that generally, but missed a few. Rob