Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932409AbdGSP5g (ORCPT ); Wed, 19 Jul 2017 11:57:36 -0400 Received: from mail.skyhub.de ([5.9.137.197]:59880 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755309AbdGSP5c (ORCPT ); Wed, 19 Jul 2017 11:57:32 -0400 Date: Wed, 19 Jul 2017 17:57:18 +0200 From: Borislav Petkov To: "Luck, Tony" Cc: Mauro Carvalho Chehab , "Kani, Toshimitsu" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "mchehab@kernel.org" , "rjw@rjwysocki.net" , "srinivas.pandruvada@linux.intel.com" , "lenb@kernel.org" , "linux-acpi@vger.kernel.org" , "linux-edac@vger.kernel.org" Subject: Re: [PATCH 3/3] ghes_edac: add platform check to enable ghes_edac Message-ID: <20170719155718.GD16124@nazgul.tnic> References: <20170717215912.26070-1-toshi.kani@hpe.com> <20170717215912.26070-4-toshi.kani@hpe.com> <20170718060007.GB8736@nazgul.tnic> <1500407379.2042.21.camel@hpe.com> <20170718181545.32bd9181@vento.lan> <20170719055838.GF26030@nazgul.tnic> <3908561D78D1C84285E8C5FCA982C28F6130D126@ORSMSX114.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F6130D126@ORSMSX114.amr.corp.intel.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 865 Lines: 27 On Wed, Jul 19, 2017 at 03:14:32PM +0000, Luck, Tony wrote: > Later when GHES gives you a NODE/CARD/MODULE) in an error record. You need > to match these up. But SMBIOS only gave you two strings "Locator" and "Bank > Locator" which have no defined syntax. You are at the mercy of the BIOS writer > to put in something parseable. Well, at some point it is only so much we can do, right? I mean, if FW says it wants to do firmware-first and we go and adhere to that, it should be expected that said FW vendor marks the silkscreen labels and DMI data accordingly. I mean, it is time for FW to put its money where its mouth is, no? How else would you do this? Firmware First but the kernel does the figuring out which DIMMs are where. So FW can't have the cake and eat it too. :-) -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --