Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933125AbdGSQQb (ORCPT ); Wed, 19 Jul 2017 12:16:31 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:38466 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932935AbdGSQQ0 (ORCPT ); Wed, 19 Jul 2017 12:16:26 -0400 Subject: Re: [PATCH v3 1/3] of: overlay: add overlay unittest data for node names and symbols To: Rob Herring References: <1500436340-7748-1-git-send-email-frowand.list@gmail.com> <1500436340-7748-2-git-send-email-frowand.list@gmail.com> Cc: Pantelis Antoniou , Pantelis Antoniou , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Frank Rowand Message-ID: <596F85CE.7000301@gmail.com> Date: Wed, 19 Jul 2017 09:16:14 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1826 Lines: 62 On 07/19/17 06:39, Rob Herring wrote: > On Tue, Jul 18, 2017 at 10:52 PM, wrote: >> From: Frank Rowand >> >> Add nodes and properties to overlay_base and overlay dts files to >> test for >> - incorrect existing node name detection when overlay node name >> has a unit-address >> - adding overlay __symbols__ properties to live tree when an >> overlay is added to the live tree >> >> The following console messages will appear near the end of unittest >> until the code errors are corrected: >> >> OF: Duplicate name in fairway-1, renamed to "ride@100#1" >> >> ### dt-test ### FAIL of_unittest_overlay_high_level():2296 Adding overlay 'overlay_bad_symbol' failed >> >> ### dt-test ### end of unittest - 190 passed, 1 failed >> >> Signed-off-by: Frank Rowand >> --- > >> diff --git a/drivers/of/unittest-data/overlay.dts b/drivers/of/unittest-data/overlay.dts >> index 6cd7e6a0c13e..81140adbe770 100644 >> --- a/drivers/of/unittest-data/overlay.dts >> +++ b/drivers/of/unittest-data/overlay.dts >> @@ -25,7 +25,18 @@ >> #size-cells = <1>; >> status = "ok"; >> >> - ride@200 { >> + ride@100 { >> + >> + track@3 { > > These need a reg property. OK. I changed track@3 to track@30, and track@4 to track@40. Then I added the reg property to .../ride@100/track@30/ and .../ride@100/track@40/ in the base dts since those nodes exist in the base dts. As a result, W=2 will still warn about a missing reg property for these two nodes in the overlay. > >> + incline_up = < 48 32 16 >; > > Don't use '_'. OK. > > Build with W=2 to check dtc warnings. OK. > > Rob >