Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755400AbdGSQoi (ORCPT ); Wed, 19 Jul 2017 12:44:38 -0400 Received: from mail-pf0-f182.google.com ([209.85.192.182]:34099 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753751AbdGSQog (ORCPT ); Wed, 19 Jul 2017 12:44:36 -0400 Date: Wed, 19 Jul 2017 09:44:31 -0700 From: Stephen Hemminger To: Mohammed Gamal Cc: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, otubo@redhat.com, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, vkuznets@redhat.com Subject: Re: [PATCH] netvsc: Remove redundant use of ipv6_hdr() Message-ID: <20170719094431.308c095b@xeon-e3> In-Reply-To: <20170719131928.18209-1-mgamal@redhat.com> References: <20170719131928.18209-1-mgamal@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1032 Lines: 28 On Wed, 19 Jul 2017 15:19:28 +0200 Mohammed Gamal wrote: > This condition already uses an object of type ipv6hdr in the line above. > Use the object directly instead of calling ipv6_hdr > > Signed-off-by: Mohammed Gamal > --- > drivers/net/hyperv/netvsc_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c > index 63c98bb..06d591c 100644 > --- a/drivers/net/hyperv/netvsc_drv.c > +++ b/drivers/net/hyperv/netvsc_drv.c > @@ -339,7 +339,7 @@ static u32 net_checksum_info(struct sk_buff *skb) > > if (ip6->nexthdr == IPPROTO_TCP) > return TRANSPORT_INFO_IPV6_TCP; > - else if (ipv6_hdr(skb)->nexthdr == IPPROTO_UDP) > + else if (ip6->nexthdr == IPPROTO_UDP) > return TRANSPORT_INFO_IPV6_UDP; > } > Patch looks fine. Network patches go through netdev@vger.kernel.org not linux driver mailing list. I will add it to my next patch of patches that are going to netdev for net-next.