Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755645AbdGSRFc (ORCPT ); Wed, 19 Jul 2017 13:05:32 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:33071 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755507AbdGSRFa (ORCPT ); Wed, 19 Jul 2017 13:05:30 -0400 Subject: Re: [PATCH v2 0/9] perf annotate: Fix --show-total-period and support --show-nr-samples To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Jiri Olsa , Milian Wolff , kernel-team@lge.com References: <1499967944-15316-1-git-send-email-treeze.taeung@gmail.com> <20170718160756.GA12241@danjae.aot.lge.com> From: Taeung Song Message-ID: <61b697ed-1cd4-71eb-dd19-8cba7364f9a7@gmail.com> Date: Thu, 20 Jul 2017 02:05:24 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170718160756.GA12241@danjae.aot.lge.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2765 Lines: 83 Hi Namhyung, I'm late. Thanks for your review. On 07/19/2017 01:07 AM, Namhyung Kim wrote: > Hi Taeung, > > On Fri, Jul 14, 2017 at 02:45:44AM +0900, Taeung Song wrote: >> Hello, >> >> Currently the --show-total-period option of perf-annotate >> is different from perf-report's. >> >> It has two problem like below: >> (Reported by Namhyung Kim and Milian Wolff) >> >> 1) Wrong column i.e. 'Percent' (even though using --show-total-period) >> 2) Show number of samples, not period >> >> So fix this option on both the annotate stdio and TUI browser. >> And support --show-nr-samples into perf-anntate >> so that it correpond with perf-report's. >> >> The code is available on 'perf/ann-fix-period-v2' branch at >> >> git://github.com/taeung/linux-perf.git >> >> Thanks, >> Taeung >> >> v2: >> - Separate the first patch into respective paches for easy review (Arnaldo) >> - Add a patch to introduce 'struct sym_hist_entry' (Arnaldo) >> - disasm__calc_percent() could receive a pointer to a struct sym_hist_entry >> instead of two pointer (Arnaldo) >> - Add a sym_hist_entry into struct disasm_line_samples (Arnaldo) >> - Fix a case that can't switch 'the total period view' to >> 'the number of samples view' on the annotate TUI browser (Arnaldo) >> - Calculate the percentage with 'period', not number of samples >> >> Taeung Song (9): >> perf annotate: Introduce struct sym_hist_entry >> perf annotate: Properly rename 'sum' to 'total_samples' in struct >> sym_hist >> perf annotate: Fix wrong --show-total-period option showing number of >> samples >> perf annotate: Show the proper header when using --show-total-period >> perf anntoate browser: Fix the toggle total period view to show >> period, not number of samples >> perf annotate browser: Show the proper header when using >> --show-total-period >> perf annotate: Support --show-nr-samples option >> perf annotate browser: Support the toggle number of samples with a 'e' >> hotkey >> perf annotate: Use the sample period when calculating the percentage > > It seems I didn't receive the patch 3 and 5 for some reason. Anyway > I have a few comments. > > Thanks, > Namhyung > > Oops, I won't miss out your email when sending the patchset v3. Thanks, Taeung >> >> tools/perf/builtin-annotate.c | 6 +- >> tools/perf/builtin-report.c | 13 ++-- >> tools/perf/builtin-top.c | 6 +- >> tools/perf/ui/browsers/annotate.c | 42 ++++++++++--- >> tools/perf/ui/gtk/annotate.c | 4 +- >> tools/perf/util/annotate.c | 125 ++++++++++++++++++++++++++------------ >> tools/perf/util/annotate.h | 15 +++-- >> 7 files changed, 148 insertions(+), 63 deletions(-) >> >> -- >> 2.7.4 >>