Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755961AbdGSRsG (ORCPT ); Wed, 19 Jul 2017 13:48:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33758 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753346AbdGSRsF (ORCPT ); Wed, 19 Jul 2017 13:48:05 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7C85F23E6C5 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=mmorsy@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7C85F23E6C5 Date: Wed, 19 Jul 2017 13:48:03 -0400 (EDT) From: Mohammed Gamal To: Stephen Hemminger Cc: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, otubo@redhat.com, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, vkuznets@redhat.com Message-ID: <930440229.36662246.1500486483200.JavaMail.zimbra@redhat.com> In-Reply-To: <20170719094431.308c095b@xeon-e3> References: <20170719131928.18209-1-mgamal@redhat.com> <20170719094431.308c095b@xeon-e3> Subject: Re: [PATCH] netvsc: Remove redundant use of ipv6_hdr() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [185.46.137.19, 10.4.196.23, 10.4.195.24] Thread-Topic: netvsc: Remove redundant use of ipv6_hdr() Thread-Index: eM3eDDsiQCpyF6OZ7bO+3ZxlQYYc7A== X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 19 Jul 2017 17:48:05 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1366 Lines: 40 ----- Original Message ----- > On Wed, 19 Jul 2017 15:19:28 +0200 > Mohammed Gamal wrote: > > > This condition already uses an object of type ipv6hdr in the line above. > > Use the object directly instead of calling ipv6_hdr > > > > Signed-off-by: Mohammed Gamal > > --- > > drivers/net/hyperv/netvsc_drv.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/hyperv/netvsc_drv.c > > b/drivers/net/hyperv/netvsc_drv.c > > index 63c98bb..06d591c 100644 > > --- a/drivers/net/hyperv/netvsc_drv.c > > +++ b/drivers/net/hyperv/netvsc_drv.c > > @@ -339,7 +339,7 @@ static u32 net_checksum_info(struct sk_buff *skb) > > > > if (ip6->nexthdr == IPPROTO_TCP) > > return TRANSPORT_INFO_IPV6_TCP; > > - else if (ipv6_hdr(skb)->nexthdr == IPPROTO_UDP) > > + else if (ip6->nexthdr == IPPROTO_UDP) > > return TRANSPORT_INFO_IPV6_UDP; > > } > > > > Patch looks fine. > Network patches go through netdev@vger.kernel.org not linux driver mailing > list. > I will add it to my next patch of patches that are going to netdev for > net-next. > Thanks for the heads up. Will take that into consideration next time. It's worth pointing out that MAINTAINERS points that files under drivers/net/hyperv are to be sent to devel@linuxdriverproject.org. Perhaps that should be updated.