Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932728AbdGSSGn (ORCPT ); Wed, 19 Jul 2017 14:06:43 -0400 Received: from mga09.intel.com ([134.134.136.24]:3757 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753502AbdGSSGl (ORCPT ); Wed, 19 Jul 2017 14:06:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,381,1496127600"; d="scan'208";a="880572410" From: "Luck, Tony" To: Borislav Petkov CC: Mauro Carvalho Chehab , "Kani, Toshimitsu" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "mchehab@kernel.org" , "rjw@rjwysocki.net" , "srinivas.pandruvada@linux.intel.com" , "lenb@kernel.org" , "linux-acpi@vger.kernel.org" , "linux-edac@vger.kernel.org" Subject: RE: [PATCH 3/3] ghes_edac: add platform check to enable ghes_edac Thread-Topic: [PATCH 3/3] ghes_edac: add platform check to enable ghes_edac Thread-Index: AQHS/4sx93QQ8jMonkW0hrLisfafFqJadtMAgAAVeYCAAJIXAIAAIm4AgACE1gD//61EYA== Date: Wed, 19 Jul 2017 18:06:25 +0000 Message-ID: <3908561D78D1C84285E8C5FCA982C28F6130D7B8@ORSMSX114.amr.corp.intel.com> References: <20170717215912.26070-1-toshi.kani@hpe.com> <20170717215912.26070-4-toshi.kani@hpe.com> <20170718060007.GB8736@nazgul.tnic> <1500407379.2042.21.camel@hpe.com> <20170718181545.32bd9181@vento.lan> <20170719055838.GF26030@nazgul.tnic> <3908561D78D1C84285E8C5FCA982C28F6130D126@ORSMSX114.amr.corp.intel.com> <20170719155718.GD16124@nazgul.tnic> In-Reply-To: <20170719155718.GD16124@nazgul.tnic> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v6JI6lsM017692 Content-Length: 1017 Lines: 24 >> Later when GHES gives you a NODE/CARD/MODULE) in an error record. You need >> to match these up. But SMBIOS only gave you two strings "Locator" and "Bank >> Locator" which have no defined syntax. You are at the mercy of the BIOS writer >> to put in something parseable. > > Well, at some point it is only so much we can do, right? > > I mean, if FW says it wants to do firmware-first and we go and adhere > to that, it should be expected that said FW vendor marks the silkscreen > labels and DMI data accordingly. > > I mean, it is time for FW to put its money where its mouth is, no? > > How else would you do this? By thinking a bit more and realizing that what I wrote up above misses that at byte offset 78 in the UEFI memory error section there is "Module Handle" which tells you which SMBIOS entry to use. So this should work just fine (as long as BIOS fills out all these fields ... there's a "Validation Bits" mask at the start of the error structure that says which fields have been populated). -Tony