Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933631AbdGSSl4 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 19 Jul 2017 14:41:56 -0400
Received: from sabertooth02.qualcomm.com ([65.197.215.38]:22669 "EHLO
        sabertooth02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756102AbdGSSl3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 19 Jul 2017 14:41:29 -0400
X-IronPort-AV: E=Sophos;i="5.40,381,1496127600"; 
   d="scan'208";a="111922071"
X-IronPort-AV: E=McAfee;i="5900,7806,8596"; a="3798929"
X-MGA-submission: =?us-ascii?q?MDESC4ePWasMydFaKXtgVThI2MQhor4UvHDJY4?=
 =?us-ascii?q?cTxACmdh1pvjdz9GgPxZa4EXfgyGuHOjGoN9UYz79O6s8KDMy88vV1vg?=
 =?us-ascii?q?TjpzU0jVCpe9GrklMYGwNF2GgVq34rRWzdIvQdbXI6JkWMVhde/+3XBG?=
 =?us-ascii?q?gj?=
From: Ryan Hsu <ryanhsu@qti.qualcomm.com>
To: Gabriel Craciunescu <nix.or.die@gmail.com>,
        "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
CC: Ryan Hsu <ryanhsu@qti.qualcomm.com>,
        "joe@perches.com" <joe@perches.com>,
        Kalle Valo <kvalo@qca.qualcomm.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg()
Thread-Topic: [PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg()
Thread-Index: AQHTAKTyJxxNPA8VZ0OeosdLleMElqJby66AgAAhAwCAAASrgA==
Date: Wed, 19 Jul 2017 18:41:27 +0000
Message-ID: <e41a39fd-87a1-7fc7-158d-cb298e46a754@qca.qualcomm.com>
References: <1500481605.25934.40.camel@perches.com>
 <20170719182454.11267-1-crazy@frugalware.org>
In-Reply-To: <20170719182454.11267-1-crazy@frugalware.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [199.106.107.6]
Content-Type: text/plain; charset="Windows-1252"
Content-ID: <78C732A787223342BC2C05C39710757C@qualcomm.com>
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v6JIg0Kg017861
Content-Length: 1232
Lines: 39

On 07/19/2017 11:24 AM, Gabriel Craciunescu wrote:

To make it consistent, maybe rename the patch title starting with ath10k:

> From: Gabriel Craciunescu <nix.or.die@gmail.com>
>
> 	Each time we get disconencted from AP we get flooded with messages like:
>
> 	...
> 	ath10k_pci 0000:03:00.0: no channel configured; ignoring frame(s)!
> 	<until ratelimit kicks in>
> 	ath10k_warn: 155 callbacks suppressed
> 	...
>
> 	Use ath10k_dbg() here too.

You don't need an indentation on every line of the commit.

> Signed-off-by: Gabriel Craciunescu <nix.or.die@gmail.com>
> ---
>  drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
> index 398dda978d6e..75d9b59b7e63 100644
> --- a/drivers/net/wireless/ath/ath10k/htt_rx.c
> +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
> @@ -1514,7 +1514,7 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar,
>  	 */
>  
>  	if (!rx_status->freq) {
> -		ath10k_warn(ar, "no channel configured; ignoring frame(s)!\n");
> +		ath10k_dbg(ar, ATH10K_DBG_HTT, "no channel configured; ignoring frame(s)!\n");
>  		return false;
>  	}
>  

-- 
Ryan Hsu