Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755201AbdGSTci (ORCPT ); Wed, 19 Jul 2017 15:32:38 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37180 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753057AbdGSTcg (ORCPT ); Wed, 19 Jul 2017 15:32:36 -0400 Date: Wed, 19 Jul 2017 21:32:29 +0200 From: Greg Kroah-Hartman To: Doug Anderson Cc: Ulf Hansson , Guenter Roeck , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Anssi Hannula , Brian Norris , "stable@vger.kernel.org" Subject: Re: [PATCH] mmc: core: Fix access to HS400-ES devices Message-ID: <20170719193229.GA8020@kroah.com> References: <1488406307-8952-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1685 Lines: 44 On Wed, Jul 19, 2017 at 11:12:45AM -0700, Doug Anderson wrote: > Hi, > > On Tue, Mar 14, 2017 at 9:22 AM, Ulf Hansson wrote: > > On 1 March 2017 at 23:11, Guenter Roeck wrote: > >> HS400-ES devices fail to initialize with the following error messages. > >> > >> mmc1: power class selection to bus width 8 ddr 0 failed > >> mmc1: error -110 whilst initialising MMC card > >> > >> This was seen on Samsung Chromebook Plus. Code analysis points to > >> commit 3d4ef329757c ("mmc: core: fix multi-bit bus width without > >> high-speed mode"), which attempts to set the bus width for all but > >> HS200 devices unconditionally. However, for HS400-ES, the bus width > >> is already selected. > >> > >> Cc: Anssi Hannula > >> Cc: Douglas Anderson > >> Cc: Brian Norris > >> Fixes: 3d4ef329757c ("mmc: core: fix multi-bit bus width ...") > >> Signed-off-by: Guenter Roeck > > > > Sorry for the delay. Been traveling. > > > > Applied for fixes, thanks! > > +stable > > The commit 3d4ef329757c ("mmc: core: fix multi-bit bus width without > high-speed mode") got backported to many stable branches, so probably > this commit 773dc118756b ("mmc: core: Fix access to HS400-ES devices") > also needs to get picked to the same stable branches. > > In the very least v4.9 and v4.4 stable includes the broken patch but > not this fix. Ah, thanks, I missed that somehow, I think I saw the fixes: field and didn't realize that that commit was already backported. I'll queue it up after these next kernels are released in a few days. thanks, greg k-h