Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933131AbdGSTlf (ORCPT <rfc822;w@1wt.eu>);
        Wed, 19 Jul 2017 15:41:35 -0400
Received: from wp244.webpack.hosteurope.de ([80.237.133.13]:54806 "EHLO
        wp244.webpack.hosteurope.de" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1754233AbdGSTle (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 19 Jul 2017 15:41:34 -0400
Date: Wed, 19 Jul 2017 21:41:31 +0200 (CEST)
From: Marcus Wolf <marcus.wolf@wolf-entwicklungen.de>
To: Joseph Wright <rjosephwright@gmail.com>, gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Message-ID: <1058637364.111448.1500493292022@ox.hosteurope.de>
In-Reply-To: <20170716144858.643-3-rjosephwright@gmail.com>
References: <20170716144858.643-1-rjosephwright@gmail.com>
 <20170716144858.643-3-rjosephwright@gmail.com>
Subject: Re: [PATCH 2/2] Staging: pi433: check error after kthread_run()
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Priority: 3
Importance: Medium
X-Mailer: Open-Xchange Mailer v7.8.3-Rev29
X-Originating-Client: com.openexchange.ox.gui.dhtml
X-bounce-key: webpack.hosteurope.de;marcus.wolf@wolf-entwicklungen.de;1500493294;92236363;
X-HE-SMSGID: 1dXuqi-0003ja-5X
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1151
Lines: 44

Hi Joseph,

tested your patch and didn't observe a problem.

Thanks for your help :-)

Marcus

> Joseph Wright <rjosephwright@gmail.com> hat am 16. Juli 2017 um 16:48
> geschrieben:
>
>
> Error should be checked with IS_ERR after calling kthread_run()
> instead of comparing the returned pointer to an int.
>
> Found by sparse warning:
>
> incompatible types for operation (<)
> left side has type struct task_struct *tx_task_struct
> right side has type int
>
> Signed-off-by: Joseph Wright <rjosephwright@gmail.com>
> ---
> drivers/staging/pi433/pi433_if.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c
> b/drivers/staging/pi433/pi433_if.c
> index 46461b4..4f724a5 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -1152,7 +1152,7 @@ static int pi433_probe(struct spi_device *spi)
> device->tx_task_struct = kthread_run(pi433_tx_thread,
> device,
> "pi433_tx_task");
> - if (device->tx_task_struct < 0)
> + if (IS_ERR(device->tx_task_struct))
> {
> dev_dbg(device->dev, "start of send thread failed");
> goto send_thread_failed;
> --
> 2.9.3
>
>