Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755277AbdGSUwh (ORCPT ); Wed, 19 Jul 2017 16:52:37 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:47268 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752172AbdGSUwg (ORCPT ); Wed, 19 Jul 2017 16:52:36 -0400 Date: Wed, 19 Jul 2017 13:52:35 -0700 (PDT) Message-Id: <20170719.135235.1392422982553298240.davem@davemloft.net> To: Eugeniy.Paltsev@synopsys.com Cc: netdev@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, alexandre.torgue@st.com, peppe.cavallaro@st.com Subject: Re: [PATCH] NET: dwmac: Make dwmac reset unconditional From: David Miller In-Reply-To: <20170718140715.25798-1-Eugeniy.Paltsev@synopsys.com> References: <20170718140715.25798-1-Eugeniy.Paltsev@synopsys.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 19 Jul 2017 13:52:36 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 627 Lines: 18 From: Eugeniy Paltsev Date: Tue, 18 Jul 2017 17:07:15 +0300 > Unconditional reset dwmac before HW init if reset controller is present. > > In existing implementation we reset dwmac only after second module > probing: > (module load -> unload -> load again [reset happens]) > > Now we reset dwmac at every module load: > (module load [reset happens] -> unload -> load again [reset happens]) > > Also some reset controllers have only reset callback instead of > assert + deassert callbacks pair, so handle this case. > > Signed-off-by: Eugeniy Paltsev Applied.