Date: Wed, 19 Jul 2017 18:19:02 -0400
From: Dennis Zhou <dennisz@fb.com>
To: Josef Bacik <josef@toxicpanda.com>
CC: Tejun Heo <tj@kernel.org>, Christoph Lameter <cl@linux.com>,
        <kernel-team@fb.com>, <linux-kernel@vger.kernel.org>,
        <linux-mm@kvack.org>, Dennis Zhou <dennisszhou@gmail.com>
Subject: Re: [PATCH 09/10] percpu: replace area map allocator with bitmap
 allocator
Message-ID: <20170719221901.GA99179@dennisz-mbp.dhcp.thefacebook.com>
References: <20170716022315.19892-1-dennisz@fb.com>
 <20170716022315.19892-10-dennisz@fb.com>
 <20170719191105.GC23135@li70-116.members.linode.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20170719191105.GC23135@li70-116.members.linode.com>
User-Agent: Mutt/1.6.1 (2016-04-27)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2017 22:19:09.0810 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR15MB0507
X-OriginatorOrg: fb.com
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-07-19_15:,,
 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 722
Lines: 17

Hi Josef,

On Wed, Jul 19, 2017 at 07:11:06PM +0000, Josef Bacik wrote:
> 
> This was a bear to review, I feel like it could be split into a few smaller
> pieces.  You are changing hinting, allocating/freeing, and how you find chunks.
> Those seem like good logical divisions to me.  Overall the design seems sound
> and I didn't spot any major problems.  Once you've split them up I'll do another
> thorough comb through and then add my reviewed by.  Thanks,

Yeah.. Thanks for taking the time. I'm currently working on responding
to Tejun's feedback and will do my best to split it down further. I've
done a bit of refactoring which should help readability and hopefully
make it easier in the next pass.

Thanks,
Dennis