Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933555AbdGSXJx (ORCPT ); Wed, 19 Jul 2017 19:09:53 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:61929 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933495AbdGSXJs (ORCPT ); Wed, 19 Jul 2017 19:09:48 -0400 From: Franklin S Cooper Jr To: , , , , , , , CC: Franklin S Cooper Jr Subject: [PATCH 1/3] can: m_can: Make hclk optional Date: Wed, 19 Jul 2017 18:09:24 -0500 Message-ID: <20170719230926.10872-2-fcooper@ti.com> X-Mailer: git-send-email 2.10.0 In-Reply-To: <20170719230926.10872-1-fcooper@ti.com> References: <20170719230926.10872-1-fcooper@ti.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1147 Lines: 33 Hclk is the MCAN's interface clock. However, for OMAP based devices such as DRA7 SoC family the interface clock is handled by hwmod. Therefore, this interface clock is managed by hwmod driver via pm_runtime_get and pm_runtime_put calls. Therefore, this interface clock isn't defined in DT and thus the driver shouldn't fail if this clock isn't found. Signed-off-by: Franklin S Cooper Jr --- drivers/net/can/m_can/m_can.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index f4947a7..7fe9145 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -1568,8 +1568,13 @@ static int m_can_plat_probe(struct platform_device *pdev) hclk = devm_clk_get(&pdev->dev, "hclk"); cclk = devm_clk_get(&pdev->dev, "cclk"); - if (IS_ERR(hclk) || IS_ERR(cclk)) { - dev_err(&pdev->dev, "no clock found\n"); + if (IS_ERR(hclk)) { + dev_warn(&pdev->dev, "can't find hclk\n"); + hclk = 0; + } + + if (IS_ERR(cclk)) { + dev_err(&pdev->dev, "cclk could not be found\n"); ret = -ENODEV; goto failed_ret; } -- 2.10.0