Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755213AbdGSXfZ (ORCPT ); Wed, 19 Jul 2017 19:35:25 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:49082 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755096AbdGSXfX (ORCPT ); Wed, 19 Jul 2017 19:35:23 -0400 Date: Wed, 19 Jul 2017 16:35:22 -0700 (PDT) Message-Id: <20170719.163522.715600112868377492.davem@davemloft.net> To: gustavo@embeddedor.com Cc: derek.chickles@caviumnetworks.com, satananda.burla@caviumnetworks.com, felix.manlunas@caviumnetworks.com, raghu.vatsavayi@caviumnetworks.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] liquidio: lio_vf_main: remove unnecessary static in setup_io_queues() From: David Miller In-Reply-To: <20170718205015.GA1420@embeddedgus> References: <20170718205015.GA1420@embeddedgus> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 19 Jul 2017 16:35:23 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 501 Lines: 13 From: "Gustavo A. R. Silva" Date: Tue, 18 Jul 2017 15:50:15 -0500 > Remove unnecessary static on local variables cpu_id_modulus and cpu_id. > Such variables are initialized before being used, on every execution > path throughout the function. The static has no benefit and, removing > it reduces the object file size. > > This issue was detected using Coccinelle and the following semantic patch: ... > Signed-off-by: Gustavo A. R. Silva Applied.