Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933180AbdGSX6c (ORCPT ); Wed, 19 Jul 2017 19:58:32 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:47576 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932187AbdGSX6b (ORCPT ); Wed, 19 Jul 2017 19:58:31 -0400 To: LKML , devel@linuxdriverproject.org, Greg Kroah-Hartman From: Randy Dunlap Cc: Marcus Wolf Subject: [PATCH -next] staging: pi433: depends on SPI Message-ID: <3d0aa578-eda9-1604-02ff-cf21e7a06a5b@infradead.org> Date: Wed, 19 Jul 2017 16:58:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1578 Lines: 39 From: Randy Dunlap The pi433 driver uses SPI interfaces so it should depend on SPI. Also, the "default n" can be removed since that is already the default. Fixes these build errors when SPI is not enabled: drivers/staging/pi433/pi433_if.o: In function `pi433_probe': pi433_if.c:(.text+0x1135): undefined reference to `spi_setup' pi433_if.c:(.text+0x1177): undefined reference to `spi_write_then_read' drivers/staging/pi433/pi433_if.o: In function `pi433_init': pi433_if.c:(.init.text+0xb8): undefined reference to `__spi_register_driver' drivers/staging/pi433/rf69.o: In function `rf69_read_fifo': rf69.c:(.text+0x102): undefined reference to `spi_sync' drivers/staging/pi433/rf69.o: In function `rf69_write_fifo': rf69.c:(.text+0x248): undefined reference to `spi_sync' drivers/staging/pi433/rf69.o: In function `rf69_read_reg': rf69.c:(.text+0x290): undefined reference to `spi_write_then_read' drivers/staging/pi433/rf69.o: In function `rf69_write_reg': rf69.c:(.text+0x523): undefined reference to `spi_sync' Signed-off-by: Randy Dunlap Cc: Marcus Wolf --- drivers/staging/pi433/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- next-2017-0719.orig/drivers/staging/pi433/Kconfig +++ next-2017-0719/drivers/staging/pi433/Kconfig @@ -1,6 +1,6 @@ config PI433 tristate "Pi433 - a 433MHz radio module for Raspberry Pi" - default n + depends on SPI ---help--- This option allows you to enable support for the radio module Pi433.