Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933853AbdGTCU4 (ORCPT ); Wed, 19 Jul 2017 22:20:56 -0400 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:51084 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933819AbdGTCUu (ORCPT ); Wed, 19 Jul 2017 22:20:50 -0400 X-IronPort-AV: E=Sophos;i="5.40,382,1496073600"; d="scan'208";a="36055161" From: Bart Van Assche To: "jejb@linux.vnet.ibm.com" , "osst@riede.org" , "sumit.saxena@broadcom.com" , "gregkh@linuxfoundation.org" , "martin.petersen@oracle.com" , "shivasharan.srikanteshwara@broadcom.com" , "kashyap.desai@broadcom.com" CC: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] SCSI: remove DRIVER_ATTR() usage Thread-Topic: [PATCH] SCSI: remove DRIVER_ATTR() usage Thread-Index: AQHTAI3An+NB/H8FgEet+6xCWadPLqJb/EQA Date: Thu, 20 Jul 2017 02:20:02 +0000 Message-ID: <1500517200.4629.0.camel@wdc.com> References: <20170719125006.GA17776@kroah.com> In-Reply-To: <20170719125006.GA17776@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linux.vnet.ibm.com; dkim=none (message not signed) header.d=none;linux.vnet.ibm.com; dmarc=none action=none header.from=wdc.com; x-originating-ip: [73.223.62.206] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1536;20:21AWv1h4PIJdUWRgrAcm4Cwr6zV29pJ+aRlTho8Sgf4nb/oXgYZuoNd73vPPcdJaba2oXNa0+DCyA+8WXdGeTNQisNV8L2gruXasFTFMyFz9GYCFSYTbUyzJgMYuU4o67sH974f8ptH21/5mVLg2dO/RObBhvLPUaApMtq25Jek= x-ms-office365-filtering-correlation-id: fd54218c-9056-4823-f91a-08d4cf15d45e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(48565401081)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CY1PR0401MB1536; x-ms-traffictypediagnostic: CY1PR0401MB1536: wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:(236129657087228); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(2017060910075)(5005006)(8121501046)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123555025)(20161123564025)(20161123560025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0401MB1536;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0401MB1536; x-forefront-prvs: 0374433C81 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(39450400003)(39400400002)(39850400002)(39840400002)(39410400002)(377424004)(24454002)(54906002)(478600001)(103116003)(99286003)(305945005)(14454004)(6246003)(2201001)(2900100001)(5660300001)(2950100002)(6506006)(6436002)(54356999)(72206003)(38730400002)(2501003)(4326008)(2906002)(33646002)(3660700001)(66066001)(50986999)(76176999)(81166006)(77096006)(53936002)(6486002)(8676002)(189998001)(3280700002)(229853002)(6116002)(8936002)(25786009)(3846002)(36756003)(102836003)(6512007)(7736002)(86362001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1536;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <6183273B35ABEF4B968E12F7787EE9C3@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2017 02:20:02.8447 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1536 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v6K2LnTw014131 Content-Length: 460 Lines: 11 On Wed, 2017-07-19 at 14:50 +0200, Greg KH wrote: > From: Greg Kroah-Hartman > > It's better to use the DRIVER_ATTR_RW() and DRIVER_ATTR_RO() macros to > explicitly show that this is a read/write or read/only sysfs file. So > convert the remaining SCSI drivers that use the old style to use the > newer macros. > > Bonus is that this removes some checkpatch.pl warnings :) Reviewed-by: Bart Van Assche