Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932983AbdGTDS3 (ORCPT ); Wed, 19 Jul 2017 23:18:29 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:56947 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932107AbdGTDS2 (ORCPT ); Wed, 19 Jul 2017 23:18:28 -0400 Subject: Re: [PATCH] watchdog: imx2_wdt: use new_timeout value to override the old To: yanjiang.jin@windriver.com, wim@iguana.be Cc: jinyanjiang@gmail.com, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170720024533.70081-1-yanjiang.jin@windriver.com> From: Guenter Roeck Message-ID: Date: Wed, 19 Jul 2017 20:18:24 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170720024533.70081-1-yanjiang.jin@windriver.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 985 Lines: 29 On 07/19/2017 07:45 PM, yanjiang.jin@windriver.com wrote: > From: Yanjiang Jin > > Without this patch we couldn't change the timeout value of imx2_wdt. > > Signed-off-by: Yanjiang Jin > --- > drivers/watchdog/imx2_wdt.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c > index 4874b0f..6cfeee6 100644 > --- a/drivers/watchdog/imx2_wdt.c > +++ b/drivers/watchdog/imx2_wdt.c > @@ -178,6 +178,9 @@ static int imx2_wdt_set_timeout(struct watchdog_device *wdog, > > regmap_update_bits(wdev->regmap, IMX2_WDT_WCR, IMX2_WDT_WCR_WT, > WDOG_SEC_TO_COUNT(new_timeout)); > + > + wdog->timeout = new_timeout; > + I must be missing something. That very same code is already in line 177, added with commit 30dd4a8f08b57 ("watchdog: imx2_wdt: also set wdog->timeout to new_timeout") back in 2015. Did you see this in an older kernel, maybe ? Guenter