Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933391AbdGTDWq (ORCPT ); Wed, 19 Jul 2017 23:22:46 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:32874 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932172AbdGTDWn (ORCPT ); Wed, 19 Jul 2017 23:22:43 -0400 Subject: Re: [PATCH v2 5/7] Input: gpio_keys - use devm_device_add_group() for attributes To: Dmitry Torokhov , Greg Kroah-Hartman Cc: htejun@gmail.com, linux-kernel@vger.kernel.org References: <20170720002436.29309-1-dmitry.torokhov@gmail.com> <20170720002436.29309-6-dmitry.torokhov@gmail.com> From: Guenter Roeck Message-ID: <23af7914-a1b0-0a37-1a0b-021832d5cc46@roeck-us.net> Date: Wed, 19 Jul 2017 20:22:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170720002436.29309-6-dmitry.torokhov@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1853 Lines: 58 On 07/19/2017 05:24 PM, Dmitry Torokhov wrote: > Now that we have proper managed API to create device attributes, let's > start using it instead of the manual unwinding. > > Signed-off-by: Dmitry Torokhov Reviewed-by: Guenter Roeck > --- > drivers/input/keyboard/gpio_keys.c | 16 ++-------------- > 1 file changed, 2 insertions(+), 14 deletions(-) > > diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c > index f52812db91bc..e9f0ebf3267a 100644 > --- a/drivers/input/keyboard/gpio_keys.c > +++ b/drivers/input/keyboard/gpio_keys.c > @@ -827,7 +827,7 @@ static int gpio_keys_probe(struct platform_device *pdev) > > fwnode_handle_put(child); > > - error = sysfs_create_group(&dev->kobj, &gpio_keys_attr_group); > + error = devm_device_add_group(dev, &gpio_keys_attr_group); > if (error) { > dev_err(dev, "Unable to export keys/switches, error: %d\n", > error); > @@ -838,22 +838,11 @@ static int gpio_keys_probe(struct platform_device *pdev) > if (error) { > dev_err(dev, "Unable to register input device, error: %d\n", > error); > - goto err_remove_group; > + return error; > } > > device_init_wakeup(dev, wakeup); > > - return 0; > - > -err_remove_group: > - sysfs_remove_group(&dev->kobj, &gpio_keys_attr_group); > - return error; > -} > - > -static int gpio_keys_remove(struct platform_device *pdev) > -{ > - sysfs_remove_group(&pdev->dev.kobj, &gpio_keys_attr_group); > - > return 0; > } > > @@ -912,7 +901,6 @@ static SIMPLE_DEV_PM_OPS(gpio_keys_pm_ops, gpio_keys_suspend, gpio_keys_resume); > > static struct platform_driver gpio_keys_device_driver = { > .probe = gpio_keys_probe, > - .remove = gpio_keys_remove, > .driver = { > .name = "gpio-keys", > .pm = &gpio_keys_pm_ops, >