Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752121AbdGTEGB (ORCPT ); Thu, 20 Jul 2017 00:06:01 -0400 Received: from mail-ua0-f169.google.com ([209.85.217.169]:32841 "EHLO mail-ua0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751876AbdGTEF7 (ORCPT ); Thu, 20 Jul 2017 00:05:59 -0400 MIME-Version: 1.0 In-Reply-To: <27236534-a9fb-53bc-f0c6-eb674833a94e@broadcom.com> References: <1500456838-18405-1-git-send-email-anup.patel@broadcom.com> <1500456838-18405-6-git-send-email-anup.patel@broadcom.com> <27236534-a9fb-53bc-f0c6-eb674833a94e@broadcom.com> From: Anup Patel Date: Thu, 20 Jul 2017 09:35:57 +0530 Message-ID: Subject: Re: [PATCH 5/5] vfio: platform: reset: Add Broadcom FlexRM reset module To: Scott Branden Cc: Will Deacon , Robin Murphy , Joerg Roedel , Baptiste Reynal , Alex Williamson , Scott Branden , Linux Kernel , Linux ARM Kernel , Linux IOMMU , kvm@vger.kernel.org, BCM Kernel Feedback Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 570 Lines: 18 On Wed, Jul 19, 2017 at 10:20 PM, Scott Branden wrote: > Hi Anup, > > NAK - as indicated in internal review please use unmodified Broadcom legal > header in its own comment block. I had addressed your internal review comments and used standard GLPv2 header (also present in other drivers). The only part I missed was to keep additional comments as separate comment block (which you had not mentioned in internal review). Anyways, I will update the comment header but I think using "NAK" in such situation is a bit over-kill Regards, Anup