Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753919AbdGTEGW convert rfc822-to-8bit (ORCPT ); Thu, 20 Jul 2017 00:06:22 -0400 Received: from mga03.intel.com ([134.134.136.65]:33573 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752142AbdGTEGU (ORCPT ); Thu, 20 Jul 2017 00:06:20 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,382,1496127600"; d="scan'208";a="880725490" From: "Chakravarty, Souvik K" To: "Bhardwaj, Rajneesh" CC: "platform-driver-x86@vger.kernel.org" , "dvhart@infradead.org" , "andy@infradead.org" , "linux-kernel@vger.kernel.org" , "Murthy, Shanth" Subject: RE: [PATCH 3/3] platform/x86: Add Audio domain PG status events Thread-Topic: [PATCH 3/3] platform/x86: Add Audio domain PG status events Thread-Index: AQHS/JftqmlRd5SHgkOATazLfNJFDKJXfPPggANWQYCAAU16YA== Date: Thu, 20 Jul 2017 04:06:14 +0000 Message-ID: <5F7315E704FA0841B5DFCE90329B2BB462E90A54@BGSMSX102.gar.corp.intel.com> References: <1500033228-634-1-git-send-email-rajneesh.bhardwaj@intel.com> <1500033228-634-3-git-send-email-rajneesh.bhardwaj@intel.com> <5F7315E704FA0841B5DFCE90329B2BB462E90061@BGSMSX102.gar.corp.intel.com> <20170719133825.GA18905@raj-desk1.iind.intel.com> In-Reply-To: <20170719133825.GA18905@raj-desk1.iind.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3237 Lines: 83 > -----Original Message----- > From: Bhardwaj, Rajneesh > Sent: Wednesday, July 19, 2017 7:08 PM > To: Chakravarty, Souvik K > Cc: platform-driver-x86@vger.kernel.org; dvhart@infradead.org; > andy@infradead.org; linux-kernel@vger.kernel.org; Murthy, Shanth > > Subject: Re: [PATCH 3/3] platform/x86: Add Audio domain PG status events > > On Mon, Jul 17, 2017 at 10:48:30AM +0530, Chakravarty, Souvik K wrote: > > > > > > > -----Original Message----- > > > From: Bhardwaj, Rajneesh > > > Sent: Friday, July 14, 2017 5:24 PM > > > To: platform-driver-x86@vger.kernel.org > > > Cc: dvhart@infradead.org; andy@infradead.org; linux- > > > kernel@vger.kernel.org; Murthy, Shanth ; > > > Chakravarty, Souvik K ; Bhardwaj, > > > Rajneesh > > > Subject: [PATCH 3/3] platform/x86: Add Audio domain PG status events > > > > > > From: "Murthy, Shanth" > > > > > > This patch adds events to ioss telemetry to read the power gating > > > status for the audio domain. > > > > > > Signed-off-by: Shanth Murthy > > > Signed-off-by: Rajneesh Bhardwaj > > > --- > > > arch/x86/include/asm/intel_telemetry.h | 2 +- > > > drivers/platform/x86/intel_telemetry_pltdrv.c | 6 ++++++ > > > 2 files changed, 7 insertions(+), 1 deletion(-) > > > > > > diff --git a/arch/x86/include/asm/intel_telemetry.h > > > b/arch/x86/include/asm/intel_telemetry.h > > > index 85029b58d0cd..4eeae0a4f9a2 100644 > > > --- a/arch/x86/include/asm/intel_telemetry.h > > > +++ b/arch/x86/include/asm/intel_telemetry.h > > > @@ -17,7 +17,7 @@ > > > #define INTEL_TELEMETRY_H > > > > > > #define TELEM_MAX_EVENTS_SRAM 28 > > > -#define TELEM_MAX_OS_ALLOCATED_EVENTS 20 > > > +#define TELEM_MAX_OS_ALLOCATED_EVENTS 25 > > > > This is something that should not be done without testing. There was an > understanding to not use more than 20 counters in OS, so that tools like > SoCWatch could use the rest 8 without total reconfiguration of the events. > With this change we are not leaving much for tools and it may break > SoCwatch/IMON or other tools dependent on using just 8. > > The better way for this would be for the userspace tool to configure the > extra 5 events via add_config() call and not increase the OS usage ceiling. > > > > Or you could add some more sysfs apis for get/set events and do it via a > daemon/script. > > > > .... > > Thanks for the review and the feedback Souvik. Ideally user space tools > should not put a restriction such as this one. It would be good to document > such details. Theoretically yes. But many of the tools have no maintaince budget/owner. > > Is there a plan to support more than 20 events in telemetry driver? If not > then we can probably think of removing few events and add audio related > events maintaining total count of 20? Sure...why not. > > For now i will respin the patches and drop this one. Thanks. I will also add support for an 'add' sysfs entry so that you can configure it easily and not have to fiddle with the default set. > > -- > Best Regards, > Rajneesh