Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933946AbdGTHDR (ORCPT ); Thu, 20 Jul 2017 03:03:17 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:36233 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932864AbdGTHDP (ORCPT ); Thu, 20 Jul 2017 03:03:15 -0400 MIME-Version: 1.0 In-Reply-To: <1498556731-13087-2-git-send-email-varada@codeaurora.org> References: <1498556731-13087-1-git-send-email-varada@codeaurora.org> <1498556731-13087-2-git-send-email-varada@codeaurora.org> From: Geert Uytterhoeven Date: Thu, 20 Jul 2017 09:03:13 +0200 X-Google-Sender-Auth: cy12X9AR8xPSYtreVArgj779_1Y Message-ID: Subject: Re: [PATCH v4 01/14] spi: qup: Enable chip select support To: Varadarajan Narayanan Cc: Mark Brown , Rob Herring , Mark Rutland , Andy Gross , David Brown , linux-spi , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "open list:ARM/QUALCOMM SUPPORT" , Sham Muthayyan Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1295 Lines: 34 Hi Varadarajan, On Tue, Jun 27, 2017 at 11:45 AM, Varadarajan Narayanan wrote: > Enable chip select support for QUP versions later than v1. > The chip select support was broken in QUP version 1. Hence > the chip select support was removed earlier in commit > 4a8573abe965115bc5b064401fd669b74e985258. Since the chip > select support is functional in recent versions of QUP, > re-enabling it for QUP versions later than v1. > > Signed-off-by: Sham Muthayyan > Signed-off-by: Varadarajan Narayanan > --- a/drivers/spi/spi-qup.c > +++ b/drivers/spi/spi-qup.c > @@ -846,6 +864,9 @@ static int spi_qup_probe(struct platform_device *pdev) > if (of_device_is_compatible(dev->of_node, "qcom,spi-qup-v1.1.1")) > controller->qup_v1 = 1; I know it was not introduced by your patch, but the proper way is to obtain the version flag from spi_qup_dt_match[].data. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds