Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933881AbdGTHPp (ORCPT ); Thu, 20 Jul 2017 03:15:45 -0400 Received: from mail-wr0-f170.google.com ([209.85.128.170]:35480 "EHLO mail-wr0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932637AbdGTHPo (ORCPT ); Thu, 20 Jul 2017 03:15:44 -0400 Date: Thu, 20 Jul 2017 08:15:40 +0100 From: Lee Jones To: Enric Balletbo i Serra Cc: Jonathan Cameron , bleung@chromium.org, martinez.javier@gmail.com, Guenter Roeck , Gwendal Grignou , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, rtc-linux@googlegroups.com, Stephen Barber Subject: Re: [PATCH v3 4/4] mfd: cros_ec: add RTC as mfd subdevice Message-ID: <20170720071540.xyw4ccvqudiiusqh@dell> References: <20170712101309.6045-1-enric.balletbo@collabora.com> <20170712101309.6045-5-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170712101309.6045-5-enric.balletbo@collabora.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2073 Lines: 67 On Wed, 12 Jul 2017, Enric Balletbo i Serra wrote: > From: Stephen Barber > > If the EC supports RTC host commands, expose an RTC device. > > Signed-off-by: Stephen Barber > Signed-off-by: Enric Balletbo i Serra > --- > drivers/mfd/cros_ec.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c > index 75a27a6..ff972fb 100644 > --- a/drivers/mfd/cros_ec.c > +++ b/drivers/mfd/cros_ec.c > @@ -51,6 +51,10 @@ static const struct mfd_cell ec_pd_cell = { > .pdata_size = sizeof(pd_p), > }; > > +static const struct mfd_cell ec_rtc_cell = { > + .name = "cros-ec-rtc", > +}; > + > static irqreturn_t ec_irq_thread(int irq, void *data) > { > struct cros_ec_device *ec_dev = data; > @@ -245,6 +249,16 @@ static void cros_ec_sensors_register(struct cros_ec_device *ec_dev) > kfree(msg); > } > > +static void cros_ec_rtc_register(struct cros_ec_device *ec_dev) > +{ > + int ret; > + > + ret = mfd_add_devices(ec_dev->dev, PLATFORM_DEVID_AUTO, &ec_rtc_cell, > + 1, NULL, 0, NULL); > + if (ret) > + dev_err(ec_dev->dev, "failed to add EC RTC\n"); > +} Why do you need a new function just to call a single function? And by making it void, you're also loosing the return value. If mfd_add_devices() fails, something has gone wrong! > int cros_ec_register(struct cros_ec_device *ec_dev) > { > struct device *dev = ec_dev->dev; > @@ -294,6 +308,10 @@ int cros_ec_register(struct cros_ec_device *ec_dev) > if (cros_ec_check_features(ec_dev, EC_FEATURE_MOTION_SENSE)) > cros_ec_sensors_register(ec_dev); > > + /* Check whether this EC has RTC support */ > + if (cros_ec_check_features(ec_dev, EC_FEATURE_RTC)) > + cros_ec_rtc_register(ec_dev); > + > if (ec_dev->max_passthru) { > /* > * Register a PD device as well on top of this device. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog