Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934420AbdGTHnZ (ORCPT ); Thu, 20 Jul 2017 03:43:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48026 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933883AbdGTHnX (ORCPT ); Thu, 20 Jul 2017 03:43:23 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 596FA4A71A Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=rkrcmar@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 596FA4A71A Date: Thu, 20 Jul 2017 09:43:16 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Brijesh Singh Cc: pbonzini@redhat.com, joro@8bytes.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, Thomas.Lendacky@amd.com Subject: Re: [PATCH v2] KVM: x86: Avoid guest page table walk when gpa_available is set Message-ID: <20170720074316.GA30718@potion> References: <1495206749-25393-1-git-send-email-brijesh.singh@amd.com> <20170719111939.GA16149@potion> <3d6d983e-b8e2-ac6d-409e-38e96f2da940@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3d6d983e-b8e2-ac6d-409e-38e96f2da940@amd.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 20 Jul 2017 07:43:23 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 978 Lines: 29 2017-07-19 08:35-0500, Brijesh Singh: > On 07/19/2017 06:19 AM, Radim Krčmář wrote: > > 2017-07-17 16:32-0500, Brijesh Singh: > > > Hi Paolo and Radim > > > > > > Any comments on this patch, I could not find it in 4.13-2 branch. > > > > > > Please let me know if you want to fix something, or want me to > > > refresh and resend the patch. > > > > Sorry, I tried it during the merge window, but it didn't pass tests on > > VMX and I got distracted by other bugs before looking into the cause. > > > > Can you reproduce the fail? > > > > No worries, thanks. > > I can try to reproduce it, are you running kvm-unittest or something different? I noticed that a linux guest hung in early boot, but at least (io)apic kvm-unit-tests failed as well, IIRC. > IIRC, VMX does not set the gpa_available flag hence I am wondering what did I miss > in the patch to trigger the failure. I will debug it and let you know. It does now, in ept_violation and ept_misconfig, thanks.