Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934600AbdGTHnf (ORCPT ); Thu, 20 Jul 2017 03:43:35 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.221]:8403 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934423AbdGTHnb (ORCPT ); Thu, 20 Jul 2017 03:43:31 -0400 X-RZG-AUTH: :P2MHfkW8eP4Mre39l357AZT/I7AY/7nT2yrT1q0ngWNsKR9DbcHksQH1pt3IXLh3PHrb X-RZG-CLASS-ID: mo00 Subject: Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate To: Franklin S Cooper Jr , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-can@vger.kernel.org, wg@grandegger.com, mkl@pengutronix.de, robh+dt@kernel.org, quentin.schulz@free-electrons.com, dev.kurt@vandijck-laurijssen.be, andrew@lunn.ch References: <20170719233654.25908-1-fcooper@ti.com> <20170719233654.25908-2-fcooper@ti.com> From: Oliver Hartkopp Message-ID: Date: Thu, 20 Jul 2017 09:43:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170719233654.25908-2-fcooper@ti.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 468 Lines: 29 Hi Franklin, On 07/20/2017 01:36 AM, Franklin S Cooper Jr wrote: > +#ifdef CONFIG_OF > +void of_transceiver_is_fixed(struct net_device *dev) > +{ (..) > +} > +EXPORT_SYMBOL(of_transceiver_is_fixed); > +#endif I'm not sure about the naming here. As this is a CAN transceiver related option it should be named accordingly: E.g. can_transceiver_is_fixed of_can_transceiver_is_fixed ... Especially as it is defined in include/linux/can/dev.h Regards, Oliver