Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934566AbdGTIMo (ORCPT ); Thu, 20 Jul 2017 04:12:44 -0400 Received: from mail.skyhub.de ([5.9.137.197]:33326 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934337AbdGTIMS (ORCPT ); Thu, 20 Jul 2017 04:12:18 -0400 Date: Thu, 20 Jul 2017 10:12:07 +0200 From: Borislav Petkov To: Arvind Yadav Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, tony.luck@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] x86: microcode: constify attribute_group structures. Message-ID: <20170720081207.GA18424@nazgul.tnic> References: <1500535305-9369-1-git-send-email-arvind.yadav.cs@gmail.com> <1500535305-9369-8-git-send-email-arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1500535305-9369-8-git-send-email-arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 718 Lines: 21 On Thu, Jul 20, 2017 at 12:51:45PM +0530, Arvind Yadav wrote: > attribute_group are not supposed to change at runtime. All functions > working with attribute_group provided by work with > const attribute_group. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 3614 545 1560 5719 1657 x86/kernel/cpu/microcode/core.o > > File size After adding 'const': > text data bss dec hex filename > 3742 417 1560 5719 1657 x86/kernel/cpu/microcode/core.o Again, what are those before/after sizes supposed to show? -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --