Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934636AbdGTIS4 (ORCPT ); Thu, 20 Jul 2017 04:18:56 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:37923 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934287AbdGTISw (ORCPT ); Thu, 20 Jul 2017 04:18:52 -0400 Subject: Re: [PATCH 7/7] x86: microcode: constify attribute_group structures. To: Borislav Petkov References: <1500535305-9369-1-git-send-email-arvind.yadav.cs@gmail.com> <1500535305-9369-8-git-send-email-arvind.yadav.cs@gmail.com> <20170720081207.GA18424@nazgul.tnic> Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, tony.luck@intel.com, linux-kernel@vger.kernel.org From: Arvind Yadav Message-ID: <27e82108-10c3-a411-d6ad-c399b603db82@gmail.com> Date: Thu, 20 Jul 2017 13:48:17 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170720081207.GA18424@nazgul.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 796 Lines: 19 Hi, On Thursday 20 July 2017 01:42 PM, Borislav Petkov wrote: > On Thu, Jul 20, 2017 at 12:51:45PM +0530, Arvind Yadav wrote: >> attribute_group are not supposed to change at runtime. All functions >> working with attribute_group provided by work with >> const attribute_group. So mark the non-const structs as const. >> >> File size before: >> text data bss dec hex filename >> 3614 545 1560 5719 1657 x86/kernel/cpu/microcode/core.o >> >> File size After adding 'const': >> text data bss dec hex filename >> 3742 417 1560 5719 1657 x86/kernel/cpu/microcode/core.o > Again, what are those before/after sizes supposed to show? It's just show, how much bytes move from data segment to text segment. ~arvind