Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934771AbdGTIap (ORCPT ); Thu, 20 Jul 2017 04:30:45 -0400 Received: from mail.skyhub.de ([5.9.137.197]:34042 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933750AbdGTI3A (ORCPT ); Thu, 20 Jul 2017 04:29:00 -0400 Date: Thu, 20 Jul 2017 10:28:50 +0200 From: Borislav Petkov To: Arvind Yadav Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, tony.luck@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] x86: microcode: constify attribute_group structures. Message-ID: <20170720082850.GB18424@nazgul.tnic> References: <1500535305-9369-1-git-send-email-arvind.yadav.cs@gmail.com> <1500535305-9369-8-git-send-email-arvind.yadav.cs@gmail.com> <20170720081207.GA18424@nazgul.tnic> <27e82108-10c3-a411-d6ad-c399b603db82@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <27e82108-10c3-a411-d6ad-c399b603db82@gmail.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 704 Lines: 30 On Thu, Jul 20, 2017 at 01:48:17PM +0530, Arvind Yadav wrote: > It's just show, how much bytes move from data segment to text segment. > ~arvind 3614 545 1560 5719 1657 x86/kernel/cpu/microcode/core.o 3614 + 545 = 4159 3742 417 1560 5719 1657 x86/kernel/cpu/microcode/core.o 3742 + 417 = 4159 3742 - 3614 = 128 So 128 bytes moved to text. I fail to see how this is relevant. Your commit message contains not really relevant info for such a simple change. Rather, it should just be a one-liner: "Constify attribute_group structs because they don't change at runtime." That's it. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --